-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add progress bar to refutation operations since they take a long time to run #368
Comments
I'll start on this. |
Okay, I've finished adding the progress bars to the refuters themselves. Now, I'm thinking about how to include options to silence them when not needed. I'm thinking to add a keyword argument to CausalRefuter.refute_estimate (like "disable_progress_bar" or smth). Then I probably also need to modify CausalModel.refute_estimate to have this argument also, so that users can silence the progress bars even if they aren't using the refuter object directly. I will just do this if that works. |
yes, that sounds good @leo-ware In addition, you can add any additional libraries used to the requirements.txt file. |
I would be willing to work on this, we can add this to the estimator as well. |
thanks, great to hear @yemaedahrav. If you have any questions as you start implementing it, you can ping on the #refutations channel on Discord. |
I have implemented this with the show_progress_bar={True/False} option. I have made the commit here. Once the other pull request is closed, I will create another PR for this. |
Any updates on this? |
I guess my PR #567 addressed this, this issue can be closed |
Suggested by @sjgenco in #367
This would require
tqdm
at the appropriate places in the loop for refutation functions.tqdm
as a requirement for DoWhy.The text was updated successfully, but these errors were encountered: