Upgrade to RuboCop 1.0 #46
Conversation
Specifying the runtime version is enough.
|
Any update regarding this? As this is blocking upgrading to Rubocop 1.x |
|
@tphoney ? |
|
@highb ? |
|
@wagenet I'll take a look when I have a moment today. Thanks for pinging me! As an FYI, I'm no longer working at Puppet and when I left Puppet no longer had an i18n team so maintenance of this repo may become a challenge as time goes on. If you wanted to try to find a path to co-maintainership, I can try reaching out to my contacts at Puppet to figure that out. That being said, I do still have permission to review PRs so I'll add my eyeballs. Thank you for your patience! |
|
@highb thanks for taking a look! Unfortunately, I'm unlikely to be able to contribute myself. My main concern in getting this moving again is because another dependency that I rely upon needs this one, even though I don't use the features. That said, this change does seem plausible to me. |
|
Approved, but unable to merge. Hopefully someone at Puppet can take a look soon. 🤞 |
In order to support the 1.x versions of Rubocop, three additional dependencies also require upgrades: - rubocop-sequel, the update to which is already complete and released; - rubocop-i18n, the update to which is in-flight (see puppetlabs/rubocop-i18n#46) - rubocop-migrations, the update to which is in-flight (see redbooth/rubocop-migrations#3) The commit here will pass CI, but the in-flight PRs should be merged and released to RubyGems before merging this PR.
|
@tphoney or @HelenCampbell it looks like you contributed to this repository in the past. Can you please review and merge this PR? |
|
Just re-verified locally that tests pass, and rubocop checks are happy so going to merge now. |
|
@highb thank you for your work on this and for cutting the 3.0 release. I see this repo is no longer archived. Are you going to continue to play a role in maintaining for at least a little while? |
|
@rickychilcott Yep, that's my plan. I'll continue to maintain this in my personal time. As noted, the repo is unarchived and I have admin access on the repo now so I should be able to perform any necessary maintainership tasks. I also have contacts within the Puppet team that I can reach out to if we encounter any issues. |
Fixes #45