Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPDATE] gems' version dependency #47

Closed
wants to merge 1 commit into from
Closed

[UPDATE] gems' version dependency #47

wants to merge 1 commit into from

Conversation

sfeuga
Copy link
Contributor

@sfeuga sfeuga commented Nov 8, 2020

In a Gemfile if you use Rubocop 1.2, you face an issue to install this gem:

rubocop-i18n (~> 2.0, >= 2.0.2) was resolved to 2.0.2, which depends on
  rubocop (~> 0.51)

According to the gem documentation I propose to update the version of rubocop in the rubocop-i18n.gemspec file.

Tested on Fedora 32 with ruby --version ruby 2.6.5p114 (2019-10-01 revision 67812) [x86_64-linux].

@sfeuga sfeuga requested a review from tphoney as a code owner November 8, 2020 16:13
@sfeuga
Copy link
Contributor Author

sfeuga commented Nov 8, 2020 •
edited

@mvz PR #46 should update rubocop-i18n.gemspec from spec.add_runtime_dependency 'rubocop', '~> 1.0' to spec.add_runtime_dependency 'rubocop', '>= 1.0' and this PR can be close.

@mvz
Copy link
Contributor

mvz commented Nov 9, 2020

@sfeuga ~> 1.0 will accept 1.2, so I'm not sure why you would want me to make that change?

@sfeuga
Copy link
Contributor Author

sfeuga commented Nov 9, 2020

Ok, my bad, It was an issue on my RVM Gemsset 🤦
I close this issue

@sfeuga sfeuga closed this Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tphoney tphoney Awaiting requested review from tphoney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfeuga @mvz