Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added comments for methods in class Page #7348

Closed
wants to merge 47 commits into from
Closed

Added comments for methods in class Page #7348

wants to merge 47 commits into from

Commits on May 24, 2021

  1. fix: modified comment for method product, platform and newPage

    @tasneemkoushar
    tasneemkoushar committed May 24, 2021
    Copy the full SHA
    66cd9ad View commit details
    Browse the repository at this point in the history

  2. fix: added comment for browsercontext, StartCSSCoverage, StartJSCoverage

    @tasneemkoushar
    tasneemkoushar committed May 24, 2021
    Copy the full SHA
    380c692 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Merge branch 'puppeteer:main' into main

    @tasneemkoushar
    tasneemkoushar committed May 25, 2021
    Copy the full SHA
    fa052ff View commit details
    Browse the repository at this point in the history

  2. fix: corrected comments for JSONValue, asElement, evaluateHandle

    @tasneemkoushar
    tasneemkoushar committed May 25, 2021
    Copy the full SHA
    a512249 View commit details
    Browse the repository at this point in the history

  3. fix: corrected comments for JSONValue, asElement, evaluateHandle

    @tasneemkoushar
    tasneemkoushar committed May 25, 2021
    Copy the full SHA
    d635188 View commit details
    Browse the repository at this point in the history

  4. fix: added comments for some of the method

    @tasneemkoushar
    tasneemkoushar committed May 25, 2021
    Copy the full SHA
    135627b View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. Merge branch 'main' into main

    @jackfranklin
    jackfranklin committed May 26, 2021
    Copy the full SHA
    faeaca9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'puppeteer:main' into main

    @tasneemkoushar
    tasneemkoushar committed May 26, 2021
    Copy the full SHA
    b07be0b View commit details
    Browse the repository at this point in the history

  3. fix: added proper comments

    @tasneemkoushar
    tasneemkoushar committed May 26, 2021
    Copy the full SHA
    fb4fd16 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of https://github.com/tasneemkoushar/puppeteer in… 

    …to main
    @tasneemkoushar
    tasneemkoushar committed May 26, 2021
    Copy the full SHA
    1fde5b2 View commit details
    Browse the repository at this point in the history

  5. fix: added comment for some methods in page.ts

    @tasneemkoushar
    tasneemkoushar committed May 26, 2021
    Copy the full SHA
    e010f9b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'puppeteer:main' into main

    @tasneemkoushar
    tasneemkoushar committed May 26, 2021
    Copy the full SHA
    0f1aee5 View commit details
    Browse the repository at this point in the history

  7. fix: rectified the comments

    @tasneemkoushar
    tasneemkoushar committed May 26, 2021
    Copy the full SHA
    11cf610 View commit details
    Browse the repository at this point in the history

  8. fix: changed some of the comments

    @tasneemkoushar
    tasneemkoushar committed May 26, 2021
    Copy the full SHA
    ff2c3eb View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into main

    @tasneemkoushar
    tasneemkoushar committed May 26, 2021
    Copy the full SHA
    3509b18 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. Merge branch 'main' into main

    @tasneemkoushar
    tasneemkoushar committed May 27, 2021
    Copy the full SHA
    9db24e1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into main

    @tasneemkoushar
    tasneemkoushar committed May 27, 2021
    Copy the full SHA
    fef4d0e View commit details
    Browse the repository at this point in the history

Commits on May 31, 2021

  1. Merge branch 'main' into main

    @tasneemkoushar
    tasneemkoushar committed May 31, 2021
    Copy the full SHA
    ba4fce9 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2021

  1. Merge branch 'main' into main

    @tasneemkoushar
    tasneemkoushar committed Jun 2, 2021
    Copy the full SHA
    96ad0e4 View commit details
    Browse the repository at this point in the history

  2. fix: added comments for 3 more methods of class page

    @tasneemkoushar
    tasneemkoushar committed Jun 2, 2021
    Copy the full SHA
    138f8b3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'puppeteer:main' into main

    @tasneemkoushar
    tasneemkoushar committed Jun 2, 2021
    Copy the full SHA
    bfc5a04 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of https://github.com/tasneemkoushar/puppeteer in… 

    …to main
    @tasneemkoushar
    tasneemkoushar committed Jun 2, 2021
    Copy the full SHA
    0e39e25 View commit details
    Browse the repository at this point in the history

  5. fix: added comments for 3 more methods of class page

    @tasneemkoushar
    tasneemkoushar committed Jun 2, 2021
    Copy the full SHA
    540eaa7 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. Merge branch 'puppeteer:main' into main

    @tasneemkoushar
    tasneemkoushar committed Jun 8, 2021
    Copy the full SHA
    284adef View commit details
    Browse the repository at this point in the history

  2. fix: added comments for 5 more methods in class page

    @tasneemkoushar
    tasneemkoushar committed Jun 8, 2021
    Copy the full SHA
    3d199b1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/tasneemkoushar/puppeteer in… 

    …to main
    @tasneemkoushar
    tasneemkoushar committed Jun 8, 2021
    Copy the full SHA
    6509e3b View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. Merge branch 'puppeteer:main' into main

    @tasneemkoushar
    tasneemkoushar committed Jun 10, 2021
    Copy the full SHA
    9b20cca View commit details
    Browse the repository at this point in the history

  2. fix: removed the extra whitespace

    @tasneemkoushar
    tasneemkoushar committed Jun 10, 2021
    Copy the full SHA
    2c2d5b8 View commit details
    Browse the repository at this point in the history

  3. fix: added comments for 5 more method in page class

    @tasneemkoushar
    tasneemkoushar committed Jun 10, 2021
    Copy the full SHA
    6b85d7c View commit details
    Browse the repository at this point in the history

  4. fix: added comments for 5 more methods in class page

    @tasneemkoushar
    tasneemkoushar committed Jun 10, 2021
    Copy the full SHA
    ceb9dea View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2021

  1. fix: commented 12 more methods in class Page

    @tasneemkoushar
    tasneemkoushar committed Jun 13, 2021
    Copy the full SHA
    1d9f8a9 View commit details
    Browse the repository at this point in the history

  2. fix: commented 12 methods in class Page

    @tasneemkoushar
    tasneemkoushar committed Jun 13, 2021
    Copy the full SHA
    17ae42e View commit details
    Browse the repository at this point in the history

  3. fix: commented 12 more methods in class Page

    @tasneemkoushar
    tasneemkoushar committed Jun 13, 2021
    Copy the full SHA
    b02e3e3 View commit details
    Browse the repository at this point in the history

  4. fix: commented 12 more methods in class Page

    @tasneemkoushar
    tasneemkoushar committed Jun 13, 2021
    Copy the full SHA
    369148d View commit details
    Browse the repository at this point in the history

  5. Added comments for methods in class Page (#7328) 

    * fix: modified comment for method product, platform and newPage

* fix: added comment for browsercontext, StartCSSCoverage, StartJSCoverage

* fix: corrected comments for JSONValue, asElement, evaluateHandle

* fix: corrected comments for JSONValue, asElement, evaluateHandle

* fix: added comments for some of the method

* fix: added proper comments

* fix: added comment for some methods in page.ts

* fix: rectified the comments

* fix: changed some of the comments

* fix: added comments for 3 more methods of class page

* fix: added comments for 3 more methods of class page

* fix: added comments for 5 more methods in class page

* fix: removed the extra whitespace

* fix: added comments for 5 more method in page class

* fix: added comments for 5 more methods in class page

* fix: commented 12 more methods in class Page

* fix: commented 12 methods in class Page

* fix: commented 12 more methods in class Page

* fix: commented 12 more methods in class Page

Co-authored-by: Jack Franklin <jacktfranklin@chromium.org>
    @tasneemkoushar @jackfranklin
    tasneemkoushar and jackfranklin committed Jun 13, 2021
    Copy the full SHA
    75fd2ba View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. Merge branch 'main' into main

    @tasneemkoushar
    tasneemkoushar committed Jun 14, 2021
    Copy the full SHA
    ae2b33a View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. Merge branch 'main' into main

    @tasneemkoushar
    tasneemkoushar committed Jun 15, 2021
    Copy the full SHA
    ba9d6ce View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2021

  1. fix: added comments for methods in class page

    @tasneemkoushar
    tasneemkoushar committed Jun 20, 2021
    Copy the full SHA
    e9355f6 View commit details
    Browse the repository at this point in the history

  2. added comments for some more methods in class page (#7341) 

    * fix: modified comment for method product, platform and newPage

* fix: added comment for browsercontext, StartCSSCoverage, StartJSCoverage

* fix: corrected comments for JSONValue, asElement, evaluateHandle

* fix: corrected comments for JSONValue, asElement, evaluateHandle

* fix: added comments for some of the method

* fix: added proper comments

* fix: added comment for some methods in page.ts

* fix: rectified the comments

* fix: changed some of the comments

* fix: added comments for 3 more methods of class page

* fix: added comments for 3 more methods of class page

* fix: added comments for 5 more methods in class page

* fix: removed the extra whitespace

* fix: added comments for 5 more method in page class

* fix: added comments for 5 more methods in class page

* fix: commented 12 more methods in class Page

* fix: commented 12 methods in class Page

* fix: commented 12 more methods in class Page

* fix: commented 12 more methods in class Page

* chore: fix typo in connection.spec.js (#7326)

recieved -> received

* chore: synchronize Bug 1710839: update comment about firefox preference remote.enabled (#7324)

* fix: added comments for methods in class page

Co-authored-by: Jack Franklin <jacktfranklin@chromium.org>
Co-authored-by: Ikko Ashimine <eltociear@gmail.com>
Co-authored-by: Julian Descottes <julian.descottes@gmail.com>
    @tasneemkoushar @jackfranklin
    @eltociear @juliandescottes
    4 people committed Jun 20, 2021
    Copy the full SHA
    ae440f5 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Merge branch 'main' into main

    @tasneemkoushar
    tasneemkoushar committed Jun 21, 2021
    Copy the full SHA
    076ed05 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. fix: added comments

    @tasneemkoushar
    tasneemkoushar committed Jun 22, 2021
    Copy the full SHA
    745d1ac View commit details
    Browse the repository at this point in the history

  2. fix: comments added

    @tasneemkoushar
    tasneemkoushar committed Jun 22, 2021
    Copy the full SHA
    ad32d5f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into main

    @tasneemkoushar
    tasneemkoushar committed Jun 22, 2021
    Copy the full SHA
    b73d910 View commit details
    Browse the repository at this point in the history

  4. fix: added comments

    @tasneemkoushar
    tasneemkoushar committed Jun 22, 2021
    Copy the full SHA
    7dc07a2 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of https://github.com/tasneemkoushar/puppeteer in… 

    …to main
    @tasneemkoushar
    tasneemkoushar committed Jun 22, 2021
    Copy the full SHA
    0074f2e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'proper-TSDoc-comments' into main

    @tasneemkoushar
    tasneemkoushar committed Jun 22, 2021
    Copy the full SHA
    d41c787 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Merge branch 'main' into main

    @jackfranklin
    jackfranklin committed Jun 23, 2021
    Copy the full SHA
    be40944 View commit details
    Browse the repository at this point in the history