Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comments for methods in class Page #7348

Closed
wants to merge 47 commits into from
Closed

Added comments for methods in class Page #7348

wants to merge 47 commits into from

Conversation

tasneemkoushar
Copy link
Contributor

No description provided.

tasneemkoushar and others added 30 commits May 24, 2021 11:18
tasneemkoushar and others added 16 commits June 13, 2021 21:26
* fix: modified comment for method product, platform and newPage

* fix: added comment for browsercontext, StartCSSCoverage, StartJSCoverage

* fix: corrected comments for JSONValue, asElement, evaluateHandle

* fix: corrected comments for JSONValue, asElement, evaluateHandle

* fix: added comments for some of the method

* fix: added proper comments

* fix: added comment for some methods in page.ts

* fix: rectified the comments

* fix: changed some of the comments

* fix: added comments for 3 more methods of class page

* fix: added comments for 3 more methods of class page

* fix: added comments for 5 more methods in class page

* fix: removed the extra whitespace

* fix: added comments for 5 more method in page class

* fix: added comments for 5 more methods in class page

* fix: commented 12 more methods in class Page

* fix: commented 12 methods in class Page

* fix: commented 12 more methods in class Page

* fix: commented 12 more methods in class Page

Co-authored-by: Jack Franklin <jacktfranklin@chromium.org>
* fix: modified comment for method product, platform and newPage

* fix: added comment for browsercontext, StartCSSCoverage, StartJSCoverage

* fix: corrected comments for JSONValue, asElement, evaluateHandle

* fix: corrected comments for JSONValue, asElement, evaluateHandle

* fix: added comments for some of the method

* fix: added proper comments

* fix: added comment for some methods in page.ts

* fix: rectified the comments

* fix: changed some of the comments

* fix: added comments for 3 more methods of class page

* fix: added comments for 3 more methods of class page

* fix: added comments for 5 more methods in class page

* fix: removed the extra whitespace

* fix: added comments for 5 more method in page class

* fix: added comments for 5 more methods in class page

* fix: commented 12 more methods in class Page

* fix: commented 12 methods in class Page

* fix: commented 12 more methods in class Page

* fix: commented 12 more methods in class Page

* chore: fix typo in connection.spec.js (#7326)

recieved -> received

* chore: synchronize Bug 1710839: update comment about firefox preference remote.enabled (#7324)

* fix: added comments for methods in class page

Co-authored-by: Jack Franklin <jacktfranklin@chromium.org>
Co-authored-by: Ikko Ashimine <eltociear@gmail.com>
Co-authored-by: Julian Descottes <julian.descottes@gmail.com>
@google-cla
Copy link

google-cla bot commented Jun 22, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 22, 2021
@google-cla
Copy link

google-cla bot commented Jun 23, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@jackfranklin
Copy link
Collaborator

Closing in favour of #7355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants