Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: turn on PdfOopif for PDF viewer #12370

Merged
merged 2 commits into from
May 2, 2024
Merged

fix: turn on PdfOopif for PDF viewer #12370

merged 2 commits into from
May 2, 2024

Commits on May 2, 2024

  1. fix: ignore frames removed by PDF viewer 

    PDF viewer in Chrome replaces the inner iframes
with an extension web view. The iframes are still
observable in Puppeteer up until the point when
they get replaces. In this case, Chrome sends
the frameDetached event with the reason swap.

Unlike the regular swap where a frame is replace with
an OOPIF or vice versa, with PDF viewer the frame is
just gone. This PR works around this issue by
ignoring any frames that are being swapped.
    @OrKoN
    OrKoN committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9e47984 View commit details
    Browse the repository at this point in the history

  2. chore: revert

    @OrKoN
    OrKoN committed May 2, 2024
    Configuration menu
    Copy the full SHA
    44ffc19 View commit details
    Browse the repository at this point in the history