fix: turn on PdfOopif for PDF viewer #12370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/fix-pdf-viewer
branch
4 times, most recently
from
f715ed5
to
5d3a2ce
Compare
OrKoN
force-pushed
the
orkon/fix-pdf-viewer
branch
2 times, most recently
from
a10f0c7
to
659c5b0
Compare
OrKoN
changed the title
OrKoN
force-pushed
the
orkon/fix-pdf-viewer
branch
7 times, most recently
from
9e76e4c
to
2a7319f
Compare
OrKoN
changed the title
OrKoN
changed the title
OrKoN
force-pushed
the
orkon/fix-pdf-viewer
branch
3 times, most recently
from
debf5b0
to
9afe9b1
Compare
OrKoN
force-pushed
the
orkon/fix-pdf-viewer
branch
from
9afe9b1
to
f85c5fc
Compare
OrKoN
force-pushed
the
orkon/fix-pdf-viewer
branch
from
f85c5fc
to
55a1d16
Compare
Lightning00Blade
approved these changes
May 2, 2024
OrKoN
force-pushed
the
orkon/fix-pdf-viewer
branch
2 times, most recently
from
f689f88
to
2411734
Compare
PDF viewer in Chrome replaces the inner iframes with an extension web view. The iframes are still observable in Puppeteer up until the point when they get replaces. In this case, Chrome sends the frameDetached event with the reason swap. Unlike the regular swap where a frame is replace with an OOPIF or vice versa, with PDF viewer the frame is just gone. This PR works around this issue by ignoring any frames that are being swapped.
OrKoN
force-pushed
the
orkon/fix-pdf-viewer
branch
from
2411734
to
44ffc19
Compare
Merged
kblok
reviewed
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OOPIFs are supported by Puppeteer whereas a guest view is not. Chrome plans to eventually move the PDF viewer to OOPIFs and we can already enable it in Puppeteer. This should consistently fix the linked issues except for #10715 which appears to be a general bug with local frames turning OOPIFs.
Refs: #12292, #10696, #12172