chore(agnostify): Create Node and Web initializer. #6477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiasbynens
approved these changes
Oct 7, 2020
This PR splits `initialize.ts` into two files, one for web, and one for Node. The Node initializer requires much more information as it needs to know which browser(s) to download and where to store them, whereas the web one does not. A future PR that I'm working on will tidy up `src/common/Puppeteer.ts` (as it contains a lot of Node specific logic around downloading and installing browsers), but this change enables us to stop the browser bundle attempting to use the `pkg-dir` dependency, which wouldn't work within a browser, as well as keeping the size of the PRs down and avoiding one mammoth PR.
jackfranklin
force-pushed
the
remove-pkg-dir-browser
branch
from
745adea
to
a0e97af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits
initialize.tsinto two files, one for web, and one forNode. The Node initializer requires much more information as it needs to
know which browser(s) to download and where to store them, whereas the
web one does not.
A future PR that I'm working on will tidy up
src/common/Puppeteer.ts(as it contains a lot of Node specific logic around downloading and
installing browsers), but this change enables us to stop the browser
bundle attempting to use the
pkg-dirdependency, which wouldn't workwithin a browser, as well as keeping the size of the PRs down and
avoiding one mammoth PR.