Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(agnostify): Create Node and Web initializer. #6477

Merged
merged 2 commits into from
Oct 7, 2020
Merged

chore(agnostify): Create Node and Web initializer. #6477

merged 2 commits into from
Oct 7, 2020
+51 −6

Commits on Oct 7, 2020

  1. chore(agnostify): Create Node and Web initializer. 

    This PR splits `initialize.ts` into two files, one for web, and one for
Node. The Node initializer requires much more information as it needs to
know which browser(s) to download and where to store them, whereas the
web one does not.

A future PR that I'm working on will tidy up `src/common/Puppeteer.ts`
(as it contains a lot of Node specific logic around downloading and
installing browsers), but this change enables us to stop the browser
bundle attempting to use the `pkg-dir` dependency, which wouldn't work
within a browser, as well as keeping the size of the PRs down and
avoiding one mammoth PR.
    @jackfranklin
    jackfranklin committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    a0e97af View commit details
    Browse the repository at this point in the history

  2. fix core

    @jackfranklin
    jackfranklin committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    330d111 View commit details
    Browse the repository at this point in the history