-
Notifications
You must be signed in to change notification settings - Fork 9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(agnostify): Create Node and Web initializer.
This PR splits `initialize.ts` into two files, one for web, and one for Node. The Node initializer requires much more information as it needs to know which browser(s) to download and where to store them, whereas the web one does not. A future PR that I'm working on will tidy up `src/common/Puppeteer.ts` (as it contains a lot of Node specific logic around downloading and installing browsers), but this change enables us to stop the browser bundle attempting to use the `pkg-dir` dependency, which wouldn't work within a browser, as well as keeping the size of the PRs down and avoiding one mammoth PR.
- Loading branch information
1 parent
3afe193
commit 745adea
Showing
4 changed files
with
44 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/** | ||
* Copyright 2020 Google Inc. All rights reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { Puppeteer } from './common/Puppeteer.js'; | ||
|
||
export const initializePuppeteerWeb = (packageName: string): Puppeteer => { | ||
const isPuppeteerCore = packageName === 'puppeteer-core'; | ||
|
||
// puppeteer-core ignores environment variables | ||
return new Puppeteer( | ||
// Product root directory is undefined as we're not concerned about | ||
// downloading and installing browsers in the web environment | ||
undefined, | ||
// Preferred revision is undefined as we will use the browser we are running in. | ||
undefined, | ||
isPuppeteerCore, | ||
// Preferred product is undefined as we'll just use the browser we are | ||
// running in. | ||
undefined | ||
); | ||
}; |