Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a Meaningful error msg for control server port taken #3204

Merged
merged 8 commits into from
Aug 25, 2023
Merged

Added a Meaningful error msg for control server port taken #3204

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
328e235
Caught Bind error and added a meaningfull erro mesaage
dhavalsingh Aug 8, 2023
46d836e
removed comment
dhavalsingh Aug 8, 2023
727d3e1
rubocop lint fix
dhavalsingh Aug 8, 2023
0be67b6
cleanup
dhavalsingh Aug 8, 2023
04b2965
raised std err
dhavalsingh Aug 10, 2023
db3b640
Re-raised the actual error. Catching EADDRINUSE instead of Std err
dhavalsingh Aug 16, 2023
7eae30b
Merge branch 'master' into control_server_port_error_enhancment
dhavalsingh Aug 17, 2023
69eb8f5
Merge branch 'master' into control_server_port_error_enhancment
dhavalsingh Aug 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/puma/runner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,11 @@ def start_control
control = Puma::Server.new app, nil,
{ min_threads: 0, max_threads: 1, queue_requests: false, log_writer: @log_writer }

control.binder.parse [str], nil, 'Starting control server'
begin
control.binder.parse [str], nil, 'Starting control server'
rescue Errno::EADDRINUSE => e
raise "Error: Control server address '#{str}' is already in use. You're trying to start a control server but the control server port is taken."
end
nateberkopec marked this conversation as resolved.
Show resolved Hide resolved

control.run thread_name: 'ctl'
@control = control
Expand Down
5 changes: 5 additions & 0 deletions test/config/activate_control_app.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
activate_control_app "tcp://0.0.0.0:9393"

app do |env|
[200, {}, ["OK"]]
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this file added? Can't see in the diff that it is being used