Added a Meaningful error msg for control server port taken #3204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhavalsingh
changed the title
dentarg
reviewed
Aug 8, 2023
test/config/activate_control_app.rb
Outdated
|
|
||
| app do |env| | ||
| [200, {}, ["OK"]] | ||
| end |
There was a problem hiding this comment.
Why was this file added? Can't see in the diff that it is being used
nateberkopec
requested changes
Aug 15, 2023
nateberkopec
changed the title
|
Also, this branch is out-of-date with the base branch |
|
You can do either, but I would recommend squashing the commits if you go for rebase. When merged, everything will be squashed anyway. |
|
@nateberkopec this can be merged now? |
|
Thank you @dhavalsingh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe your pull request. Thank you for contributing! You're the best.
Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.Closes issue 3204
Might close issue #2894 too.