-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add built-in systemd notify support #3011
Conversation
I wasn't able to identify why there are some tests failing. Could someone help me with that? |
Re the macOS failures, it looks like line 115 in assert_match(/Connection refused|Couldn't connect to server/, rejected_curl_stderr.read) Or, the error message reported by curl has changed? Let me check... |
@MSP-Greg macOS-11 2.6 test is still failing. Any idea why? |
Nothing to do with this PR. Intermittent test failure from hell. I just noticed something re comments in sd_notify.rb. Most doc systems will attach the comments below Maybe CI will pass... |
@MSP-Greg thank you! I did what you suggested and now all tests are passing. |
I'm not sure how clear routines we have for backports (almost never happens in my experience) but https://github.com/puma/puma/tree/5-6-stable looks to be the same as https://github.com/puma/puma/releases/tag/v5.6.5 (I draw this conclusion from the release saying Then there is this branch https://github.com/puma/puma/tree/5-6-5 I think @nateberkopec can provide more guidance on backporting |
@joaomarcos96 Yes, that is correct. In this case though, because we're adding a feature, we should probably create a new minor version |
@nateberkopec Yes, I'd like that. |
👍 We now have a |
As a Fedora maintainer, I am disappointed with this PR and with bundling in general. What was the reason to not specify the dependency in .gemspec? If at least the code was put into dedicated directory to make this more obvious. And if at least the license field was updated to list the |
Description
This PR aims to remove the need to install the sd_notify gem by vendoring its code, thus, making the support for systemd notify built-in.
I have considered what @mperham have done with Sidekiq and said about
sd_notify
#2438 (comment):Your checklist for this pull request
sd_notify
gem code was copied exactly as it is.[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.