Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] - test_integration_single.rb - fix curl msg regex #3012

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

MSP-Greg
Copy link
Member

@MSP-Greg MSP-Greg commented Nov 4, 2022

Description

Fix regex used to test curl output message when connection refused.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg merged commit f323d12 into puma:master Nov 4, 2022
@MSP-Greg MSP-Greg deleted the 00-fix-curl-msg branch November 4, 2022 20:52
@dentarg
Copy link
Member

dentarg commented Nov 4, 2022

Motivation for this change: #3011 (comment)

@MSP-Greg
Copy link
Member Author

MSP-Greg commented Nov 5, 2022

Since CI logs are flushed based on age, below is the error that started appearing in CI on macOS 11, added some line breaks:

TestIntegrationSingle#test_term_not_accepts_new_connections
[/Users/runner/work/puma/puma/test/test_integration_single.rb:115]:
Expected /Connection refused/ to match
"  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0\r  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (7) Failed to connect to 127.0.0.1 port 51683 after 3 ms: Couldn't connect to server\n".

So rather than 'Connection refused', it's logging 'Couldn't connect to server'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants