Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close connection in web server tests [skip changelog] #2072

Merged
merged 1 commit into from Nov 11, 2019
Merged

Close connection in web server tests [skip changelog] #2072

merged 1 commit into from Nov 11, 2019

Commits on Nov 11, 2019

  1. Close connection in web server tests 

    [skip changelog]

Closes puma#2049

Before this commit, `test_trickle_attack` and
`test_file_streamed_request` were each taking an extra 20 seconds to run.

Without the `Connection: close` header, the [connection was kept
alive][keep alive] until it timed out after the
[`PERSISTENT_TIMEOUT`][PERSISTENT_TIMEOUT] duration of 20 seconds.

[keep alive]: https://github.com/puma/puma/blob/3835ac74dec5511d637cbc4ebc140c3b8632b447/lib/puma/server.rb#L706-L708
[PERSISTENT_TIMEOUT]: https://github.com/puma/puma/blob/3835ac74dec5511d637cbc4ebc140c3b8632b447/lib/puma/const.rb#L109-L111
    @composerinteralia
    composerinteralia committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    86d6405 View commit details
    Browse the repository at this point in the history