Close connection in web server tests [skip changelog] #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composerinteralia
changed the title
[skip changelog] Closes puma#2049 Before this commit, `test_trickle_attack` and `test_file_streamed_request` were each taking an extra 20 seconds to run. Without the `Connection: close` header, the [connection was kept alive][keep alive] until it timed out after the [`PERSISTENT_TIMEOUT`][PERSISTENT_TIMEOUT] duration of 20 seconds. [keep alive]: https://github.com/puma/puma/blob/3835ac74dec5511d637cbc4ebc140c3b8632b447/lib/puma/server.rb#L706-L708 [PERSISTENT_TIMEOUT]: https://github.com/puma/puma/blob/3835ac74dec5511d637cbc4ebc140c3b8632b447/lib/puma/const.rb#L109-L111
composerinteralia
force-pushed
the
close-connection
branch
from
398fde8
to
86d6405
Compare
hahmed
approved these changes
Nov 11, 2019
|
💯 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2049
Before this commit,
test_trickle_attackandtest_file_streamed_requestwere each taking an extra 20 seconds to run.Without the
Connection: closeheader, the connection was keptalive until it timed out after the
PERSISTENT_TIMEOUTduration of 20 seconds.Your checklist for this pull request
[changelog skip]to all commit messages.[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.