The --expect-no-changes flag checks for output diffs
#15903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-05-01)Bug Fixes
|
Frassle
reviewed
Apr 12, 2024
| @@ -162,7 +163,9 @@ func displayUpdatesJSON(updates []backend.UpdateInfo, decrypter config.Decrypter | |||
| info.EndTime = makeStringRef(time.Unix(update.EndTime, 0).UTC().Format(timeFormat)) | |||
| resourceChanges := make(map[string]int) | |||
| for k, v := range update.ResourceChanges { | |||
| resourceChanges[string(k)] = v | |||
| if k != deploy.OpOutputChange { | |||
There was a problem hiding this comment.
Why do we filter out OpOutputChange here? That's not obvious from context, deserves an explanation comment.
| newOutputs := step.New().Outputs | ||
| diff := oldOutputs.Diff(newOutputs) | ||
| if diff.AnyChanges() { | ||
| acts.Ops[deploy.OpOutputChange] += len(diff.Adds) + len(diff.Deletes) + len(diff.Updates) |
There was a problem hiding this comment.
Feels odd that this counts per-field changes rather than a count of how many resources made any change. Is there a reason to prefer this rather than just +1 here?
There was a problem hiding this comment.
In the scenarios where this number is shown to the user, this then means that the number shown matches the listed output diffs
| @@ -823,7 +823,7 @@ func TestStackReferenceSecretsNodejs(t *testing.T) { | |||
| { | |||
| Dir: filepath.Join(d, "nodejs", "step2"), | |||
| Additive: true, | |||
| ExpectNoChanges: true, | |||
| ExpectNoChanges: false, | |||
There was a problem hiding this comment.
Can just remove the field, it defaults to false.
Frassle
approved these changes
Apr 12, 2024
PollRobots
force-pushed
the
proberts/expect-no-changes-should-check-output
branch
from
6ca6016
to
1f7ee5e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tgummerer
reviewed
Apr 15, 2024
| changes: | ||
| - type: fix | ||
| scope: cli/engine | ||
| description: "Fixes #15564, --expect-no-changes now causes pulumi cli to fail if the only changes are output changes" |
There was a problem hiding this comment.
Suggested change
| description: "Fixes #15564, --expect-no-changes now causes pulumi cli to fail if the only changes are output changes" | |
| description: "Make --expect-no-changes fail if the only changes are output changes" |
PollRobots
force-pushed
the
proberts/expect-no-changes-should-check-output
branch
2 times, most recently
from
8927a32
to
5a4a942
Compare
PollRobots
force-pushed
the
proberts/expect-no-changes-should-check-output
branch
from
5a4a942
to
6c2125f
Compare
|
This is now safe with pulumi-service |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
PollRobots
force-pushed
the
proberts/expect-no-changes-should-check-output
branch
from
6c2125f
to
8a13150
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
PollRobots
added a commit
that referenced
this pull request
May 6, 2024
This reverts commit b72399b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a pseudo op
OpOutputChangeto the set of changes that are recorded indisplay.ResourceChangesto count the number of output changes, this is then included in the check used to evaluate the--expect-no-changesflagWhen resource outputs are registered, they are checked against their previous value using existing functionality, the total count of changes is then added
The internal capability is validated with an engine test, the cli is validated using an integration test
This will break user workflows that depend on the previous behavior
Fixes #15564
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change