Fixes from review comments

changelog/pending/20240410--cli-engine--fixes-15564-expect-no-changes-now-causes-pulumi-cli-to-fail-if-the-only-changes-are-output-changes.yaml

@@ -1,4 +1,4 @@
 changes:
 - type: fix
   scope: cli/engine
-  description: "Fixes #15564, --expect-no-changes now causes pulumi cli to fail if the only changes are output changes"
+  description: "Make --expect-no-changes fail even if the only changes are output changes"

pkg/cmd/pulumi/stack_history.go

@@ -163,6 +163,8 @@ func displayUpdatesJSON(updates []backend.UpdateInfo, decrypter config.Decrypter
 			info.EndTime = makeStringRef(time.Unix(update.EndTime, 0).UTC().Format(timeFormat))
 			resourceChanges := make(map[string]int)
 			for k, v := range update.ResourceChanges {
+				// Filter out the the OpOutputChange events because they are pseudo
+				// events that shouldn't be included in the stack history
 				if k != deploy.OpOutputChange {
 					resourceChanges[string(k)] = v
 				}

pkg/engine/lifecycletest/pulumi_test.go

@@ -5720,10 +5720,10 @@ func TestOutputChanges(t *testing.T) {
 		"frob": "baz",
 	})
 	programF := deploytest.NewLanguageRuntimeF(func(_ plugin.RunInfo, monitor *deploytest.ResourceMonitor) error {
-		urn, _, _, _, err := monitor.RegisterResource("pkgA:m:typA", "resA", true, deploytest.ResourceOptions{})
+		rrResp, err := monitor.RegisterResource("pkgA:m:typA", "resA", true, deploytest.ResourceOptions{})
 		assert.NoError(t, err)
 
-		err = monitor.RegisterResourceOutputs(urn, outs)
+		err = monitor.RegisterResourceOutputs(rrResp.URN, outs)
 		assert.NoError(t, err)
 
 		return nil