Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to ensure invoking pulumi:pulumi:getResource keeps resource refs #11522

Merged
merged 1 commit into from Dec 18, 2022

Conversation

justinvp
Copy link
Member

@justinvp justinvp commented Dec 2, 2022

Following up from #11382

Fixes #11384

@justinvp justinvp added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Dec 2, 2022
@pulumi-bot
Copy link
Contributor

pulumi-bot commented Dec 2, 2022

Changelog

[uncommitted] (2022-12-18)

@justinvp
Copy link
Member Author

justinvp commented Dec 2, 2022

🤔 The new Node.js test is failing in CI but not for me locally. Need to investigate why.

@justinvp
Copy link
Member Author

The new Node.js test is failing in CI but not for me locally

I haven't been able to reproduce the error locally and it's working now in CI so 🤷

@justinvp justinvp force-pushed the justin/resourcereftests branch 2 times, most recently from f1e7b58 to c99cef4 Compare December 16, 2022 16:23
@justinvp
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 18, 2022

Build succeeded:

@bors bors bot merged commit 36b0c2f into master Dec 18, 2022
@bors bors bot deleted the justin/resourcereftests branch December 18, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests to ensure invoking pulumi:pulumi:getResource keeps resource refs
3 participants