New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test that ensures invoking pulumi:pulumi:getResource
keeps resource refs
#9
Conversation
🍹 The Update for pulumi/testproj/xookguhg was successful. Resource Changes Name Type Operation
+ testproj-xookguhg pulumi:pulumi:Stack create
|
This comment has been minimized.
This comment has been minimized.
🍹 The Update for pulumi/testproj/saipmtww was successful. Resource Changes Name Type Operation
+ testproj-saipmtww pulumi:pulumi:Stack create
|
🍹 The Update for pulumi/testproj/lyotlyeq was successful. Resource Changes Name Type Operation
+ testproj-lyotlyeq pulumi:pulumi:Stack create
|
🍹 The Update (preview) for pulumi/testproj/lyotlyeq was successful. Resource Changes Name Type Operation
+ testproj-lyotlyeq pulumi:pulumi:Stack create
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you please add the test to the list of integration tests in .github/workflows/pr.yml
? This way it runs on CI as well 😄
I will replace this list later with dotnet run all-integration-tests
probably, I did this because it gives a nice view of which tests failed when they do but keeping it in sync might be a hassle
🍹 The Update for pulumi/testproj/botmlsiz was successful. Resource Changes Name Type Operation
+ testproj-botmlsiz pulumi:pulumi:Stack create
|
This comment has been minimized.
This comment has been minimized.
🍹 The Update for pulumi/testproj/rohfxiru was successful. Resource Changes Name Type Operation
+ testproj-rohfxiru pulumi:pulumi:Stack create
|
🍹 The Update for pulumi/testproj/oltyyczy was successful. Resource Changes Name Type Operation
+ testproj-oltyyczy pulumi:pulumi:Stack create
|
🍹 The Update (preview) for pulumi/testproj/oltyyczy was successful. Resource Changes Name Type Operation
+ testproj-oltyyczy pulumi:pulumi:Stack create
|
Done
That is nice, though, I wish they'd run in parallel rather than one at a time. |
@justinvp I tried this at first but when running multiple tests that use the same local reference to the SDK, it becomes really flaky and fails at random 😞 this was my compromise to make them reliable given that there aren't that many integration tests |
Ported from pulumi/pulumi#11522
Following up from pulumi/pulumi#11382
Part of pulumi/pulumi#11384