Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test that ensures invoking pulumi:pulumi:getResource keeps resource refs #9

Merged
merged 2 commits into from Dec 14, 2022

Conversation

justinvp
Copy link
Member

Ported from pulumi/pulumi#11522

Following up from pulumi/pulumi#11382

Part of pulumi/pulumi#11384

@justinvp justinvp added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Dec 14, 2022
@pulumi-staging
Copy link

🍹 The Update for pulumi/testproj/xookguhg was successful.

Resource Changes

    Name               Type                 Operation
+   testproj-xookguhg  pulumi:pulumi:Stack  create

@pulumi-staging

This comment has been minimized.

@pulumi-staging
Copy link

🍹 The Update for pulumi/testproj/saipmtww was successful.

Resource Changes

    Name               Type                 Operation
+   testproj-saipmtww  pulumi:pulumi:Stack  create

@pulumi-staging
Copy link

🍹 The Update for pulumi/testproj/lyotlyeq was successful.

Resource Changes

    Name               Type                 Operation
+   testproj-lyotlyeq  pulumi:pulumi:Stack  create

@pulumi-staging
Copy link

🍹 The Update (preview) for pulumi/testproj/lyotlyeq was successful.

Resource Changes

    Name               Type                 Operation
+   testproj-lyotlyeq  pulumi:pulumi:Stack  create

Copy link
Contributor

@Zaid-Ajaj Zaid-Ajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you please add the test to the list of integration tests in .github/workflows/pr.yml? This way it runs on CI as well 😄

I will replace this list later with dotnet run all-integration-tests probably, I did this because it gives a nice view of which tests failed when they do but keeping it in sync might be a hassle

@pulumi-staging
Copy link

🍹 The Update for pulumi/testproj/botmlsiz was successful.

Resource Changes

    Name               Type                 Operation
+   testproj-botmlsiz  pulumi:pulumi:Stack  create

@pulumi-staging

This comment has been minimized.

@pulumi-staging
Copy link

🍹 The Update for pulumi/testproj/rohfxiru was successful.

Resource Changes

    Name               Type                 Operation
+   testproj-rohfxiru  pulumi:pulumi:Stack  create

@pulumi-staging
Copy link

🍹 The Update for pulumi/testproj/oltyyczy was successful.

Resource Changes

    Name               Type                 Operation
+   testproj-oltyyczy  pulumi:pulumi:Stack  create

@pulumi-staging
Copy link

🍹 The Update (preview) for pulumi/testproj/oltyyczy was successful.

Resource Changes

    Name               Type                 Operation
+   testproj-oltyyczy  pulumi:pulumi:Stack  create

@justinvp
Copy link
Member Author

Can you please add the test to the list of integration tests in .github/workflows/pr.yml?

Done

it gives a nice view of which tests failed

That is nice, though, I wish they'd run in parallel rather than one at a time.

@Zaid-Ajaj
Copy link
Contributor

I wish they'd run in parallel rather than one at a time.

@justinvp I tried this at first but when running multiple tests that use the same local reference to the SDK, it becomes really flaky and fails at random 😞 this was my compromise to make them reliable given that there aren't that many integration tests

@Zaid-Ajaj Zaid-Ajaj merged commit 8b2a538 into main Dec 14, 2022
@Zaid-Ajaj Zaid-Ajaj deleted the justin/getresourcetest branch December 14, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants