update some names for registry #11506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2022-12-03) |
susanev
commented
Dec 1, 2022
susanev
commented
Dec 1, 2022
susanev
added
the
impact/no-changelog-required
Signed-off-by: susanev <susan.ra.evans@gmail.com>
justinvp
requested changes
Dec 3, 2022
Comment on lines
-1561
to
+1569
| // All custom resources have an implicit `id` output property, that we must inject into the docs. | ||
| if !r.IsComponent { | ||
| filteredOutputProps = append(filteredOutputProps, &schema.Property{ | ||
| Name: "id", | ||
| Comment: "The provider-assigned unique ID for this managed resource.", | ||
| Type: schema.StringType, | ||
| }) | ||
| } | ||
| // All resources have an implicit `id` output property, that we must inject into the docs. | ||
| filteredOutputProps = append(filteredOutputProps, &schema.Property{ | ||
| Name: "id", | ||
| Comment: "The provider-assigned unique ID for this managed resource.", | ||
| Type: schema.StringType, | ||
| }) |
There was a problem hiding this comment.
This change needs to be removed from this PR. We should not be including the id property for components. I just recently fixed this in #11469
Comment on lines
+1695
to
+1702
| type fs map[string][]byte | ||
|
|
||
| func (fs fs) add(path string, contents []byte) { | ||
| _, has := fs[path] | ||
| contract.Assertf(!has, "duplicate file: %s", path) | ||
| fs[path] = contents | ||
| } | ||
|
|
There was a problem hiding this comment.
Also, all the rest of the changes related to fs (including the need to import the contract package at the top of the file) should be removed from this PR. This was a deliberate change in #11312 that shouldn't be reverted.
There was a problem hiding this comment.
@justinvp I could use your help on Monday. all of these came from what I thought was the right gen command to run, which was obviously wrong.
There was a problem hiding this comment.
well nevermind, i started over and its clean, going to close this in favor of #11525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing up some names for regsitry for seo and usability reasons