Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align names on browse and package pages #1744

Closed
anita-trimbur opened this issue Nov 30, 2022 · 11 comments
Closed

align names on browse and package pages #1744

anita-trimbur opened this issue Nov 30, 2022 · 11 comments
Assignees
Milestone

Comments

@anita-trimbur
Copy link

anita-trimbur commented Nov 30, 2022

edit for clarity: we want the names on the browse page, and the names of the detail pages pulling from the same data set. preference to pull from whatever the package detail pages are pulling from right now because those are often more detailed. we can come in later and clean up other issues in the packages themselves as needed. - @susanev


there are a few instances where an abbreviated name is used on the registry browse page that is different from the name used on the package page. see awsx as an example:

Screen Shot 2022-11-30 at 11 46 57 AM

Screen Shot 2022-11-30 at 11 47 03 AM

we would like all instances to use the more descriptive name.

@anita-trimbur anita-trimbur added kind/enhancement Improvements or new features impact/usability labels Nov 30, 2022
@kimberleyamackenzie kimberleyamackenzie self-assigned this Nov 30, 2022
@kimberleyamackenzie
Copy link
Collaborator

@anita-trimbur The data for the browse page cards and the index pages comes from two different sources, so it looks like divergence comes from when one source is hand-updated, and the other is not updated to match. I'll do an audit and put up a PR to align everything, but there's unfortunately not an easy answer that I can see that keeps them aligned going forward other than being vigilant on PRs where title attributes change.

That said, I think this should be relatively rare + it's easy enough to fix.

@kimberleyamackenzie
Copy link
Collaborator

kimberleyamackenzie commented Dec 1, 2022

Eek, much more common than I guessed above 😬 - here's an audit of what's on browse vs index when they differ. Let me know which we should go with. I will also reach out on Slack about how we can make these two names converge bc this is obviously very common, so would be ideal to come from the same source.

  • Google Cloud Classic (browse), Google Cloud (GCP) Classic (index)
  • AWSx (browse), AWSx (Pulumi Crosswalk for AWS) (index)
  • Azure Active Directory (browse), AzureAD (index)
  • Azure Quickstart ACR Geo Replication (browse), Azure Quickstart ACR Geo Replicated (index)
  • azure-justrun (browse), Azure Justrun (index)
  • Command (browse), Command (preview) (index)
  • Consul (browse), HashiCorp Consul (index)
  • ec (browse), ElasticCloud (EC) (index)
  • eventstorecloud (browse), Event Store Cloud (index)
  • Google Cloud Native (browse), Google Native (index)
  • HashiCorp Cloud Platform (HCP) (browse), HCP (index)
  • Kubernetes Cert Manager (browse), cert-manager (index)
  • Metabase (AWS) (browse), Metabase (index)
  • Nomad (browse), HashiCorp Nomad (index)
  • Proxmox VE (browse), Proxmox Virtual Environment (Proxmox VE) (index)
  • Rancher 2 (browse), Rancher2 (index)
  • Rancher RKE (browse), Rancher Kubernetes Engine (index)
  • Sumo Logic (browse), SumoLogic (index)
  • tls-self-signed-cert (browse), Self Signed Certificate (index)
  • Vault (browse), HashiCorp Vault (index)

Casing diffs

  • artifactory (browse), Artifactory (index)
  • astra (browse), Astra (index)
  • checkly (browse), Checkly (index)
  • flux (browse), Flux (index)
  • heroku (browse), Heroku (index)
  • OVH (browse), Ovh (index)
  • MinIO (browse), Minio (index)
  • random (browse), Random (index)
  • tailscale (browse), Tailscale (index)

Something going on with confluent + confluent cloud packages - one is labeled Confluent on browse, but titled confluent cloud on index and located at /confluentcloud, the one labeled Confluent Cloud on browse is also labeled Confluent Cloud on index but located at /confluent. (Aha, edited to add - it looks like https://www.pulumi.com/registry/packages/confluent/ is deprecated, but that wasn't super obvious to me when browsing so not sure if we want to address the naming diffs here).

@susanev
Copy link
Contributor

susanev commented Dec 1, 2022

id like to "fix" this by using the same data source we use on the package detail pages on the package browse page. that's the change id like to happen in the issue. i don't want us to change anything about the casing in this issue, take it exactly as its coming in and then we can fix casing issues in the packages themselves later if needed.

for improvements beyond that, id like us to open a new tracking issue, because it will mean updating individual packages.

@susanev
Copy link
Contributor

susanev commented Dec 1, 2022

will explain more about confluent in team meeting tomorrow, don't want to talk about it more here since its a public issue.

@kimberleyamackenzie
Copy link
Collaborator

@susanev I don't believe we have a straightforward way to automatically align the two names (the name shown in the browse view, and the name shown on the Overview index page). Here's my understanding of the pipeline (def gonna repeat things you already know, but typing it all out for clarity):

  1. The repo of the provider has (among other things) two separate files in it that are relevant here - schema.json and docs/_index.md. These two files are authored separately, however the maintainer of the provider sees fit.
  2. A PR is made to add that provider to the Registry, via adding to this file. That includes a url to their schema.json.
  3. Once that PR is merged, this automated job creates a providerName.yaml file from the schema.json, and pulls the docs/_index.md file directly from the provider repo.
  4. The name we show in the browse page comes from the providerName.yaml file, and the name we show on the index page comes directly from the frontmatter in that docs/_index.md file.

So, as far as I understand it, it's at the discretion of the provider author/maintainer to keep those two names in sync. I think we could be clearer about that intention in the docs. I would guess that it's also possible for the automated job that adds the yaml file and the index file to the Registry repo to do some magic and change the title on the index file to match whatever is in the yaml file, but I am not sure how complicated that would be - it's a bit outside my wheelhouse.

Does that sound right, is there any part of the flow I'm misunderstanding? What do you think re next steps?

@susanev
Copy link
Contributor

susanev commented Dec 1, 2022

@kimberleyamackenzie got it thx, ill take on this issue. ill fix the biggest offenders today, and will slowly work towards fixing the rest.

@susanev susanev added this to the 0.81 milestone Dec 1, 2022
@susanev
Copy link
Contributor

susanev commented Dec 2, 2022

these need their install+config titles fixed

  • aquasec
  • astra
  • aviatrix
  • buildkite
  • checkly
  • doppler
  • dynaatrace
  • exoscale
  • flux
  • fusion auth
  • gandi
  • grafana
  • harness
  • hcp
  • heroku
  • koyeb
  • launch darkly
  • ovhcloud
  • proxmoxve
  • rootly
  • scaleway
  • sentry
  • symbiosis
  • time
  • unifi
  • upstash

@susanev
Copy link
Contributor

susanev commented Dec 2, 2022

the changes

internal

pulumiverse

lbrlabs

other

releases that need to happen

internal

  • azure ad
  • awsx
  • will add more later

lbrlabs

  • ovh
  • harness
  • launchdarkly
  • scaleway
  • grafana
  • dynatrace

pulumiverse

  • doppler
  • gandi
  • exocale
  • buildkite
  • astra
  • aquasec
  • sentry
  • time
  • astra
  • unifi
  • heroku
  • hcp

other

  • proxmoxve
  • koyeb
  • symbiosis
  • upstash
  • fusionauth
  • aviatrix
  • rootly
  • eventstorecloud
  • flux
  • checkly

@susanev
Copy link
Contributor

susanev commented Dec 3, 2022

alright i have open prs for everything except for rancher2 because i have an outstanding question about it; the tricky part now is going to be convincing everyone to do releases

@marns93
Copy link
Contributor

marns93 commented Dec 5, 2022

@susanev I've created a new release for Heroku provider. (https://github.com/pulumiverse/pulumi-heroku/actions/runs/3618262104/jobs/6098043475)

@susanev susanev modified the milestones: 0.81, 0.82 Dec 5, 2022
@susanev
Copy link
Contributor

susanev commented Dec 9, 2022

im calling this done from my perspective, stuff will slowly roll in, and that's okay!

@susanev susanev closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants