New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
align names on browse and package pages #1744
Comments
@anita-trimbur The data for the browse page cards and the index pages comes from two different sources, so it looks like divergence comes from when one source is hand-updated, and the other is not updated to match. I'll do an audit and put up a PR to align everything, but there's unfortunately not an easy answer that I can see that keeps them aligned going forward other than being vigilant on PRs where title attributes change. That said, I think this should be relatively rare + it's easy enough to fix. |
Eek, much more common than I guessed above 😬 - here's an audit of what's on browse vs index when they differ. Let me know which we should go with. I will also reach out on Slack about how we can make these two names converge bc this is obviously very common, so would be ideal to come from the same source.
Casing diffs
Something going on with confluent + confluent cloud packages - one is labeled Confluent on browse, but titled confluent cloud on index and located at /confluentcloud, the one labeled Confluent Cloud on browse is also labeled Confluent Cloud on index but located at /confluent. (Aha, edited to add - it looks like https://www.pulumi.com/registry/packages/confluent/ is deprecated, but that wasn't super obvious to me when browsing so not sure if we want to address the naming diffs here). |
id like to "fix" this by using the same data source we use on the package detail pages on the package browse page. that's the change id like to happen in the issue. i don't want us to change anything about the casing in this issue, take it exactly as its coming in and then we can fix casing issues in the packages themselves later if needed. for improvements beyond that, id like us to open a new tracking issue, because it will mean updating individual packages. |
will explain more about confluent in team meeting tomorrow, don't want to talk about it more here since its a public issue. |
@susanev I don't believe we have a straightforward way to automatically align the two names (the name shown in the browse view, and the name shown on the Overview index page). Here's my understanding of the pipeline (def gonna repeat things you already know, but typing it all out for clarity):
So, as far as I understand it, it's at the discretion of the provider author/maintainer to keep those two names in sync. I think we could be clearer about that intention in the docs. I would guess that it's also possible for the automated job that adds the yaml file and the index file to the Registry repo to do some magic and change the title on the index file to match whatever is in the yaml file, but I am not sure how complicated that would be - it's a bit outside my wheelhouse. Does that sound right, is there any part of the flow I'm misunderstanding? What do you think re next steps? |
@kimberleyamackenzie got it thx, ill take on this issue. ill fix the biggest offenders today, and will slowly work towards fixing the rest. |
these need their install+config titles fixed
|
alright i have open prs for everything except for rancher2 because i have an outstanding question about it; the tricky part now is going to be convincing everyone to do releases |
@susanev I've created a new release for Heroku provider. (https://github.com/pulumiverse/pulumi-heroku/actions/runs/3618262104/jobs/6098043475) |
im calling this done from my perspective, stuff will slowly roll in, and that's okay! |
edit for clarity: we want the names on the browse page, and the names of the detail pages pulling from the same data set. preference to pull from whatever the package detail pages are pulling from right now because those are often more detailed. we can come in later and clean up other issues in the packages themselves as needed. - @susanev
there are a few instances where an abbreviated name is used on the registry browse page that is different from the name used on the package page. see awsx as an example:
we would like all instances to use the more descriptive name.
The text was updated successfully, but these errors were encountered: