Remove Dotnet from release step of GH workflow #11684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2022-12-20) |
RobbieMcKinstry
added
the
impact/no-changelog-required
AaronFriel
requested changes
Dec 19, 2022
.github/workflows/release.yml
Outdated
| @@ -42,7 +42,6 @@ on: | |||
| # Example provided for illustration, this value is derived by scripts/get-job-matrix.py build | |||
| default: | | |||
| { | |||
| "dotnet": "6.0.x", | |||
There was a problem hiding this comment.
This should be retained, it's an example value and it's kept consistent across all of our workflows. If this is removed, someone might incorrectly believe the dotnet key isn't available here.
|
@RobbieMcKinstry pushing snapshot versions to package managers again is blocked by #10627. Summary: I tried to run our entire workflow for a prerelease version and this was unpopular - it caused us to push a prerelease to our Docs pipeline, Homebrew, and others. |
AaronFriel
approved these changes
Dec 20, 2022
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that dotnet has been exfiltrated to https://github.com/pulumi/pulumi-dotnet we do not release it as part of the release workflow. The release step errors since the dotnet artifacts are no longer uploaded to GitHub as part of the release bundle.
Is there an easy way to test this change?
Checklist
make changelogand committed thechangelog/pending/<file>documenting my change