Skip to content

Commit

Permalink
Merge #11684
Browse files Browse the repository at this point in the history
11684: Remove Dotnet from release step of GH workflow r=AaronFriel a=RobbieMcKinstry

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

Now that dotnet has been exfiltrated to https://github.com/pulumi/pulumi-dotnet we do not release it as part of the release workflow. The release step errors since the dotnet artifacts are no longer uploaded to GitHub as part of the release bundle.

Is there an easy way to test this change?

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->


## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


Co-authored-by: Robbie McKinstry <robbie@pulumi.com>
  • Loading branch information
bors[bot] and RobbieMcKinstry committed Dec 20, 2022
2 parents 78c9bf4 + 62cf42a commit 0f23e35
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions .github/workflows/release.yml
Expand Up @@ -57,7 +57,6 @@ env:
PULUMI_TEST_OWNER: "moolumi"
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
NUGET_PUBLISH_KEY: ${{ secrets.NUGET_PUBLISH_KEY }}
PYPI_PASSWORD: ${{ secrets.PYPI_PASSWORD }}

jobs:
Expand All @@ -67,7 +66,7 @@ jobs:
strategy:
fail-fast: false
matrix:
language: ["nodejs", "python", "dotnet", "go"]
language: ["nodejs", "python", "go"]
steps:
- name: Checkout Repo
uses: actions/checkout@v3
Expand All @@ -83,12 +82,6 @@ jobs:
if: ${{ matrix.language == 'python' }}
run: |
python -m pip install --upgrade pip requests wheel urllib3 chardet twine
- name: Set up DotNet ${{ fromJson(inputs.version-set).dotnet }}
if: ${{ matrix.language == 'dotnet' }}
uses: actions/setup-dotnet@607fce577a46308457984d59e4954e075820f10a # v3.0.3
with:
dotnet-version: ${{ fromJson(inputs.version-set).dotnet }}
dotnet-quality: ga
- name: Set up Node ${{ fromJson(inputs.version-set).nodejs }}
if: ${{ matrix.language == 'nodejs' }}
uses: actions/setup-node@v3
Expand Down

0 comments on commit 0f23e35

Please sign in to comment.