Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dotnet from release step of GH workflow #11684

Merged
merged 2 commits into from Dec 20, 2022
Merged

Remove Dotnet from release step of GH workflow #11684

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e15e727
Remove Dotnet from release step of GH workflow
RobbieMcKinstry Dec 19, 2022
62cf42a
Add dotnet back into the matrix
RobbieMcKinstry Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 1 addition & 9 deletions .github/workflows/release.yml
View file
Open in desktop
Expand Up @@ -42,7 +42,6 @@ on:
# Example provided for illustration, this value is derived by scripts/get-job-matrix.py build
default: |
{
"dotnet": "6.0.x",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be retained, it's an example value and it's kept consistent across all of our workflows. If this is removed, someone might incorrectly believe the dotnet key isn't available here.

"go": "1.18.x",
"nodejs": "14.x",
"python": "3.9.x"
Expand All @@ -57,7 +56,6 @@ env:
PULUMI_TEST_OWNER: "moolumi"
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
NUGET_PUBLISH_KEY: ${{ secrets.NUGET_PUBLISH_KEY }}
PYPI_PASSWORD: ${{ secrets.PYPI_PASSWORD }}

jobs:
Expand All @@ -67,7 +65,7 @@ jobs:
strategy:
fail-fast: false
matrix:
language: ["nodejs", "python", "dotnet", "go"]
language: ["nodejs", "python", "go"]
steps:
- name: Checkout Repo
uses: actions/checkout@v3
Expand All @@ -83,12 +81,6 @@ jobs:
if: ${{ matrix.language == 'python' }}
run: |
python -m pip install --upgrade pip requests wheel urllib3 chardet twine
- name: Set up DotNet ${{ fromJson(inputs.version-set).dotnet }}
if: ${{ matrix.language == 'dotnet' }}
uses: actions/setup-dotnet@607fce577a46308457984d59e4954e075820f10a # v3.0.3
with:
dotnet-version: ${{ fromJson(inputs.version-set).dotnet }}
dotnet-quality: ga
- name: Set up Node ${{ fromJson(inputs.version-set).nodejs }}
if: ${{ matrix.language == 'nodejs' }}
uses: actions/setup-node@v3
Expand Down