Update provider mock to include GetMapping binding. #2256
Conversation
RobbieMcKinstry
added
the
impact/no-changelog-required
provider/pkg/provider/provider.go
Outdated
| @@ -205,6 +205,12 @@ func (k *kubeProvider) Call(ctx context.Context, req *pulumirpc.CallRequest) (*p | |||
| return nil, status.Error(codes.Unimplemented, "Call is not yet implemented") | |||
| } | |||
|
|
|||
| // GetMapping fetches the mapping for this resource provider, if any. A provider should return an empty | |||
| // response (not an error) if it doesn't have a mapping for the given key. | |||
| func (k *kubeProvider) GetMapping(ctx context.Context, req *pulumirpc.GetMappingRequest) (*GetMappingResponse, error) { | |||
There was a problem hiding this comment.
This looks correct once the pulumi SDK dependency is updated. This currently fails to typecheck because the GetMapping method isn't present in the current version of the SDK.
|
@RobbieMcKinstry, now that v3.49.0 has been release, do you want to finish up this PR? I think it's a matter of updating: pulumi-kubernetes/provider/go.mod Lines 14 to 15 in fd81fa8 and rebuilding to see if there are any generated SDK changes |
|
@justinvp yes, I'll make those changes, thanks! |
|
...right after I eat this lunch! :D <3 |
|
Ok, done. Looks like there's a merge conflict, I'll resolve that. |
RobbieMcKinstry
force-pushed
the
mckinstry/update-mocks
branch
from
828c1f7
to
791fbcd
Compare
|
Cool, that should do it! |
Does the PR have any schema changes?Looking good! No breaking changes found. |
|
Hm, bizarre CI error... transient? |
Haven't seen that one before. Let's rerun. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
Proposed changes
Update the provider mock to stub out the GetMapping grpc call.
Related issues (optional)
Downstream codegen tests are failing for pulumi/pulumi#11579 , and this appears to be the culprit.
Related test failure: https://github.com/pulumi/pulumi/actions/runs/3640177109/jobs/6144501716