Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jazzyfresh/codegen python nonstring secrets #11494

Merged
merged 1 commit into from Dec 7, 2022

Conversation

jazzyfresh
Copy link
Contributor

Description

Fixes incorrectly generated python code when secret is a non-string type.

Fixes #11278

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Nov 30, 2022

Changelog

[uncommitted] (2022-12-07)

Bug Fixes

  • [pkg] Fixes codegen/python generation of non-string secrets in provider properties
    #11494

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things, but looks good otherwise!

pkg/codegen/python/gen.go Outdated Show resolved Hide resolved
pkg/codegen/python/gen.go Outdated Show resolved Hide resolved
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justinvp
Copy link
Member

justinvp commented Dec 7, 2022

The Test kubernetes Downstream failure is due to pulumi/pulumi-kubernetes#2256, but is blocked until we do a p/p tomorrow release.

@jazzyfresh jazzyfresh force-pushed the jazzyfresh/codegen-python-nonstring-secrets branch from ec0dfb8 to 42784f6 Compare December 7, 2022 19:36
@jazzyfresh
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 7, 2022

Build succeeded:

@bors bors bot merged commit 68308f5 into master Dec 7, 2022
@bors bors bot deleted the jazzyfresh/codegen-python-nonstring-secrets branch December 7, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[codegen/python] Invalid code generated when provider config input is array and marked secret
3 participants