Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[noissue]: Update aioredis requirement from ~=2.0.0 to ~=2.0.1 #1788

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 28, 2021

Updates the requirements on aioredis to permit the latest version.

Release notes

Sourced from aioredis's releases.

v2.0.1

Version v2.0.1

Features

  • Added Python 3.10 to CI & Updated the Docs (see #1160)
  • Enable mypy in CI (see #1101)
  • Synchronized reading the responses from a connection (see #1106)

Fixes

  • Remove del from Redis (Fixes #1115) (see #1227)
  • fix socket.error raises (see #1129)
  • Fix buffer is closed error when using PythonParser class (see #1213)
Changelog

Sourced from aioredis's changelog.

2.0.1 - (2021-12-20)

Features

  • Added Python 3.10 to CI & Updated the Docs (see #1160)
  • Enable mypy in CI (see #1101)
  • Synchronized reading the responses from a connection (see #1106)

Fixes

  • Remove del from Redis (Fixes #1115) (see #1227)
  • fix socket.error raises (see #1129)
  • Fix buffer is closed error when using PythonParser class (see #1213)

2.0.0 - (2021-03-18)

Features

  • Port redis-py's client implementation to aioredis.
    (see #891)

  • Make hiredis an optional dependency.
    (see #917)

1.3.1 (2019-12-02)

Bugfixes

  • Fix transaction data decoding
    (see #657)
  • Fix duplicate calls to pool.wait_closed() upon create_pool() exception.
    (see #671)

Deprecations and Removals

  • Drop explicit loop requirement in API. Deprecate loop argument. Throw warning in Python 3.8+ if explicit loop is passed to methods.
    (see #666)

Misc

1.3.0 (2019-09-24)

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the Dependencies Pull requests that update a dependency file label Dec 28, 2021
@pulpbot
Copy link
Member

pulpbot commented Dec 28, 2021

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@mdellweg
Copy link
Member

mdellweg commented Jan 4, 2022

There seem to be features in a bugfix-release. Maybe we need to pin this dependency differently.

Updates the requirements on [aioredis](https://github.com/aio-libs/aioredis-py) to permit the latest version.
- [Release notes](https://github.com/aio-libs/aioredis-py/releases)
- [Changelog](https://github.com/aio-libs/aioredis-py/blob/master/CHANGELOG.md)
- [Commits](aio-libs-abandoned/aioredis-py@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: aioredis
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/aioredis-approx-eq-2.0.1 branch from aa9b95d to 035a2f5 Compare January 5, 2022 13:38
@bmbouter
Copy link
Member

They do label features, but they seem like bugfixes. Two of them are CI and docs fixes and the other seems like a bugfix.

That being said maybe we should pin because I don't see a claim from them if they use semver or not.

@bmbouter
Copy link
Member

They do mention semver here though aio-libs-abandoned/aioredis-py#930 (comment)

@bmbouter
Copy link
Member

I believe they follow semver and just don't document that. If that's the case I think we can merge this as is so I'm lgtm-ing it. I posted this here aio-libs-abandoned/aioredis-py#1277 to get more info on the issue.

@mdellweg
Copy link
Member

I'm fine with merging. What i don't quite get is why we need to bump the z version at all. As long as we use the ~= (Semver-operator) the here advertised package will be selected anyway. And we may even make the life of packagers easier by not requiring new dependencies all the time.

@bmbouter
Copy link
Member

I'm fine with merging. What i don't quite get is why we need to bump the z version at all. As long as we use the ~= (Semver-operator) the here advertised package will be selected anyway. And we may even make the life of packagers easier by not requiring new dependencies all the time.

There isn't a "big" reason I would say, but a small reason is that it declares that we've formally tested against it. Another small reason is it signals to the rpm build folks that they should be using a newer version of the dep.

@bmbouter bmbouter merged commit 5538069 into main Jan 19, 2022
@bmbouter bmbouter deleted the dependabot/pip/aioredis-approx-eq-2.0.1 branch January 19, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants