Fix typing on blpop (etc) timeout argument

[icgood]

What do these changes do?

Improves typing on blpop's timeout argument, which is a number of seconds (not milliseconds) and allows decimal precision:

The timeout argument is interpreted as a double value specifying the maximum number of seconds to block. A timeout of zero can be used to block indefinitely.

Other blocking b* methods were updated similarly. I also fixed some low-hanging mypy errors under tests/.

Are there changes in behavior for the user?

No change in behavior, only type hint changes.

Related issue number

N/A

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES/ folder
  • name it <issue_id>.<type> (e.g. 588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the PR
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example:
    Fix issue with non-ascii contents in doctest text files.

[codecov]

Codecov Report

Merging #1224 (8f3890c) into master (dbdd0ad) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1224      +/-   ##
==========================================
- Coverage   90.67%   90.65%   -0.03%     
==========================================
  Files          21       21              
  Lines        6875     6879       +4     
  Branches      794      794              
==========================================
+ Hits         6234     6236       +2     
- Misses        469      470       +1     
- Partials      172      173       +1     

Flag	Coverage Δ
unit	90.56% <100.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aioredis/client.py	82.56% <100.00%> (+<0.01%)	⬆️
tests/conftest.py	92.41% <100.00%> (+0.16%)	⬆️
aioredis/connection.py	77.15% <0.00%> (-0.24%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbdd0ad...8f3890c. Read the comment docs.

[Andrew-Chen-Wang]

Thanks! We'll want to change the name of the TimeoutSecT to something more specific to BL/BR ops because there are other arguments that also include a timeout argument.

[icgood]

We'll want to change the name of the TimeoutSecT to something more specific to BL/BR ops because there are other arguments that also include a timeout argument.

@Andrew-Chen-Wang Yeah, that was the reason I went with TimeoutSecT, to differentiate it from other timeout= arguments that take milliseconds. I verified that the spots I switched to TimeoutSecT were all documented as taking seconds, the same way as BLPOP. Would any of the following be preferable to you?

• TimeoutSecondsT
• SecondsT
• TimeoutSecondsT + TimeoutMillisT for millisecond values (simple alias for int).

[Andrew-Chen-Wang]

I see. I fear that some other redis command would also have seconds for timeout arg. I was thinking in terms of blocking list like BLTimeoutT, but if the only redis commands that use secondsare the blocking list primitives, then I think the current state is fine.

[Andrew-Chen-Wang]

Thanks a lot!