fix: Remove '<4' from python_requires #6333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* As discussed in https://discuss.python.org/t/use-of-less-than-next-major-version-e-g-4-in-python-requires-setup-py/1066 and other places by the PyPA, use of upper bounds with python_requires for future versions of Python is unintended use of python_requires and actively discouraged.
|
This is ready for review. |
|
It looks like this is a pretty consistent standard you've helped drive across projects. Given the comments in the discussion from the other PyPA maintainers, I think this is reasonable. Thanks @matthewfeickert! |
nateprewitt
approved these changes
Jan 19, 2023
matthewfeickert
deleted the
fix/remove-less-than-4-from-python-requires
branch
matthewarmand
pushed a commit
to matthewarmand/requests
that referenced
this pull request
May 10, 2023
* As discussed in https://discuss.python.org/t/use-of-less-than-next-major-version-e-g-4-in-python-requires-setup-py/1066 and other places by the PyPA, use of upper bounds with python_requires for future versions of Python is unintended use of python_requires and actively discouraged.
10 tasks
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6332
The
requests/setup.py
Line 97 in 61c324d
cap was added in PR #6091.
As discussed in https://discuss.python.org/t/use-of-less-than-next-major-version-e-g-4-in-python-requires-setup-py/1066 and other places by the PyPA, use of upper bounds with
python_requiresfor future versions of Python is unintended use ofpython_requiresand actively discouraged.c.f. pypa/packaging.python.org#850 for further detail.