Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add trogon to conda-forge #23391

Merged
merged 13 commits into from Aug 25, 2023
Merged

feat: Add trogon to conda-forge #23391

merged 13 commits into from Aug 25, 2023

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Jul 19, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/trogon) and found some lint.

Here's what I've got...

For recipes/trogon:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@kratsg
Copy link
Contributor Author

kratsg commented Jul 19, 2023

This is a follow-up of Textualize/trogon#49 where hopefully we'd get a LICENSE file to use. I've added other maintainers (happy to remove myself from the list).

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/trogon) and found it was in an excellent condition.

@kratsg
Copy link
Contributor Author

kratsg commented Jul 19, 2023

Also needed for conda-forge/mapyde-feedstock#14.

@kratsg
Copy link
Contributor Author

kratsg commented Aug 15, 2023

hi @conda-forge/help-python -- can you please assist with this? There is no current LICENSE file but this is holding up another upstream project I already have in conda-forge.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 15, 2023

GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.

We need all the maintainers to comment confirming they are willing to be listed.

PS: The license file is also a blocker. We need that to be able to re-package.

@kratsg
Copy link
Contributor Author

kratsg commented Aug 15, 2023

Is there any suggestions on what i can do here? The problem is that the fact that this recipe is missing is making it harder for us to maintain the downstream packages on conda-forge. The corresponding issue is still open and unresolved (Textualize/trogon#49) which is unfortunate.

And the maintainers don't seem to be responding as much, even though I've tried my best to reach out.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 15, 2023

And the maintainers don't seem to be responding as much, even though I've tried my best to reach out.

Maybe they are too busy don't have the bandwidth to maintain this recipe. You can remove them and add a recipe with just yourself.

The corresponding issue is still open and unresolved (Textualize/trogon#49) which is unfortunate.

Indeed but a library without a license cannot be packaged. I would not even use it b/c the mention of the MIT in some places there imply in the existence of a license file... that is not there.

@kratsg
Copy link
Contributor Author

kratsg commented Aug 24, 2023

Indeed but a library without a license cannot be packaged. I would not even use it b/c the mention of the MIT in some places there imply in the existence of a license file... that is not there.

Hi @ocefpaf - good news! An MIT LICENSE is now packaged in the repo. There is not quite a new release with this LICENSE but at least the code is licensed. I'll fix the pipelines, but then I think it's ready to go (I dropped other maintainers and will be happy to maintain for now).

@kratsg
Copy link
Contributor Author

kratsg commented Aug 24, 2023

For now, I'll submit an initial recipe that's from GitHub with the intention of updating it once a new release exists.

@kratsg
Copy link
Contributor Author

kratsg commented Aug 24, 2023

Hi @conda-forge/help-python - this is ready to go! I opted to set the version as a dev release to indicate that the version from GitHub tarball that has the LICENSE is close to 0.5.1 rather than 0.5.0 (to be faithful to anyone expecting 0.5.0 on conda).

The CI failed but not entirely sure why. retrying fixed it

recipes/trogon/meta.yaml Outdated Show resolved Hide resolved
recipes/trogon/meta.yaml Outdated Show resolved Hide resolved
recipes/trogon/meta.yaml Outdated Show resolved Hide resolved
recipes/trogon/meta.yaml Outdated Show resolved Hide resolved
@ocefpaf ocefpaf merged commit 21c2875 into conda-forge:main Aug 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants