Allow charset normalizer >=2 and <3 #6169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tox environments passed locally. |
|
Similar and duplicated fix from #6175 (comment):
|
sethmlarson
reviewed
Jun 24, 2022
sethmlarson
reviewed
Jun 24, 2022
frenzymadness
force-pushed
the
update_charset_normalizer
branch
from
9e9cd2a
to
6a97f1c
Compare
areche
approved these changes
Jun 27, 2022
This was referenced Jun 28, 2022
nateprewitt
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
Looks good to me, thanks @frenzymadness! We'll release this in the next patch release, 2.28.1.
Merged
22 tasks
This was referenced Jun 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current definition
charset_normalizer~=2.0.0does not allow charset-normalizer 2.1.0 which has been released a couple of hours ago. The newer version seems to be compatible with requests and the compatibility check suggests that requests should allow versions up to 3.0.