Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin charset-normalizer to 2.0.12 #74104

Merged
merged 2 commits into from Jun 28, 2022
Merged

Pin charset-normalizer to 2.0.12 #74104

merged 2 commits into from Jun 28, 2022

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Jun 28, 2022

Breaking change

Proposed change

charset-normalizer was released with version 2.1.0 9 days ago.
This version causes a conflict.

  • aiohttp==3.8.1 [requires: charset-normalizer>=2.0,<3.0]
  • requests==2.28.0 [requires: charset-normalizer~=2.0.0]

There is a PR open to loosening the requirements of requests, but until that lands in a new version of it, we should limit this to 2.0.12.
psf/requests#6169

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Jun 28, 2022
@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels Jun 28, 2022
@ludeeus ludeeus marked this pull request as ready for review June 28, 2022 09:59
@frenck
Copy link
Member

frenck commented Jun 28, 2022

Rebased the PR, not sure why, but the CI didn't trigger fully after the last commit 馃し

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 28, 2022
Dev automation moved this from Needs review to Reviewer approved Jun 28, 2022
@frenck frenck merged commit 2f60db6 into dev Jun 28, 2022
@frenck frenck deleted the pin-charset-normalizer branch June 28, 2022 16:20
Dev automation moved this from Reviewer approved to Done Jun 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Dev container fails to setup due to charset-normalizer dependency
3 participants