eip-7251: process_effective_balance_updates #14003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
force-pushed
the
eip-7251-process_effective_balance_updates
branch
from
65ae7fb
to
d349bb4
Compare
james-prysm
reviewed
May 15, 2024
james-prysm
reviewed
May 15, 2024
prestonvanloon
force-pushed
the
eip-7251-process_effective_balance_updates
branch
from
d349bb4
to
3fe6947
Compare
rkapka
reviewed
May 15, 2024
prestonvanloon
force-pushed
the
eip-7251-process_effective_balance_updates
branch
from
d6b9d0b
to
9e37da4
Compare
james-prysm
reviewed
May 21, 2024
Spectests for process_effective_balance_updates process_effective_balance_updates unit tests
prestonvanloon
force-pushed
the
eip-7251-process_effective_balance_updates
branch
from
35652f5
to
a0d5882
Compare
james-prysm
reviewed
May 24, 2024
| } | ||
|
|
||
| if balance+downwardThreshold < val.EffectiveBalance || val.EffectiveBalance+upwardThreshold < balance { | ||
| effectiveBal := min(balance-balance%effBalanceInc, effectiveBalanceLimit) |
There was a problem hiding this comment.
do we need this extra variable ? ( maybe reads more clearly?)
james-prysm
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Required for electra.
Extracted from #13903.
Which issues(s) does this PR fix?
Tracking @ #13849
Other notes for review
https://github.com/ethereum/consensus-specs/blob/v1.5.0-alpha.2/specs/electra/beacon-chain.md#updated-process_effective_balance_updates