Electra core transition operations #14001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
commented
May 22, 2024
| return nil, errors.Wrap(err, "could not process deposit receipts") | ||
| } | ||
|
|
||
| if err := electra.ProcessConsolidations(ctx, st, bod.Consolidations()); err != nil { |
There was a problem hiding this comment.
why does this not return a state like the other process functions?
There was a problem hiding this comment.
@rkapka made me do it 🤣
The better question is why do the other methods return the state when they are mutating the state argument? 🤔
There was a problem hiding this comment.
i'm not sure lol
| @@ -7,6 +7,5 @@ import ( | |||
| ) | |||
|
|
|||
| func TestMainnet_Electra_Transition(t *testing.T) { | |||
| t.Skip("TODO: Electra") | |||
There was a problem hiding this comment.
no i forgot to skip it
testing/spectest/minimal/electra/fork_transition/transition_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
prestonvanloon
approved these changes
May 23, 2024
| // ): | ||
| // validator.effective_balance = min(balance - balance % EFFECTIVE_BALANCE_INCREMENT, EFFECTIVE_BALANCE_LIMIT) | ||
| func ProcessEffectiveBalanceUpdates(state state.BeaconState) error { | ||
| // TODO: replace with real implementation |
| // if is_eligible_for_activation(state, validator): | ||
| // validator.activation_epoch = activation_epoch | ||
| func ProcessRegistryUpdates(ctx context.Context, state state.BeaconState) (state.BeaconState, error) { | ||
| // TODO: replace with real implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
taken from the electra-devnet0 branch, and adds some place holders for Electra core transition. subsequent PRs will address the contents of the processing as well as add tests
spec changes can be found https://github.com/ethereum/consensus-specs/tree/dev/specs/electra
Which issues(s) does this PR fix?
Fixes #
Other notes for review