New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore plugin autoloading as deprecated opt-in #2177
Open
bf4
wants to merge
2
commits into
pry:master
Choose a base branch
from
bf4:add_deprecated_opt_in_plugin_autoloading
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
commented
Feb 16, 2021
bf4
force-pushed
the
add_deprecated_opt_in_plugin_autoloading
branch
from
February 16, 2021 01:07
d02afed
to
04e508c
Compare
bf4
force-pushed
the
add_deprecated_opt_in_plugin_autoloading
branch
from
February 16, 2021 18:44
04e508c
to
3538f23
Compare
bf4
commented
Feb 16, 2021
# TODO: Remove enable-plugins when removing plugin auto-loading | ||
# Bring in options defined by plugins | ||
Pry::Slop.new do | ||
on "enable-plugins" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure best way to test this
marcparadise
added a commit
to chef/chef
that referenced
this pull request
Jun 28, 2021
This permits `pry-byebug` to continue working with it, until either pry/pry#2177 is merged, or deivid-rodriguez/pry-byebug#343 is otherwise resolved. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
marcparadise
added a commit
to chef/chef
that referenced
this pull request
Jun 28, 2021
This permits `pry-byebug` to continue working with it, until either pry/pry#2177 is merged, or deivid-rodriguez/pry-byebug#343 is otherwise resolved. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
johnmccrae
pushed a commit
to chef/chef
that referenced
this pull request
Jul 16, 2021
This permits `pry-byebug` to continue working with it, until either pry/pry#2177 is merged, or deivid-rodriguez/pry-byebug#343 is otherwise resolved. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #2119 (comment)