New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newest version of Pry breaks pry-byebug #343
Comments
I can reproduce this. It seems my testing was lousy. I apologize. |
Can this be solved with an |
Sorry for the delay here, I'll try to allocate some time soon to have a look. But yeah, it'd be great to find a solution that doesn't involve monkey-patching! |
I'd be interested if you wanted to test the 'opt-in' plugin behavior in pry/pry#2177 since I didn't find much of a way to test it on my own |
Check in deivid-rodriguez/pry-byebug#343 before upgrading pry.
Same problem in Pry 0.14.1 how can i resolve this problem?? |
This permits `pry-byebug` to continue working with it, until either pry/pry#2177 is merged, or deivid-rodriguez/pry-byebug#343 is otherwise resolved. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
This permits `pry-byebug` to continue working with it, until either pry/pry#2177 is merged, or deivid-rodriguez/pry-byebug#343 is otherwise resolved. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
This permits `pry-byebug` to continue working with it, until either pry/pry#2177 is merged, or deivid-rodriguez/pry-byebug#343 is otherwise resolved. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
Despite having locked @thomaswuensche said:
Where would I add this? I'm greatly missing |
OK, so I made my own version of the Here's my own
Here's the stack when I invoke
|
Any update on any chance of a pry-byebug that works with pry 0.14.0? |
Jonathan, not sure if this helps but you might want to switch to the new Ruby core Debug gem. You get all of Pry + Pry Byebug in a single gem now. I think the days of Pry are coming to an end. |
Ah, I knew the |
I didn't find |
🙇 Alexander. True, it's not a full functional replacement. Fair point. |
#386 should fix this, can someone confirm? |
I've tested with pry 0.14.1 and pry-byebug 3.10.0 and had no issues. Thanks @deivid-rodriguez ! |
Awesome, thanks for trying it! |
The Pull Request pry/pry#2119 from November changed the way plugins are loaded in Pry: they're no longer autoloaded and need to be required in .pryrc.
However, this does not work for me with pry-byebug.
Steps to reproduce:
require 'pry-byebug'
to .pryrcrequire 'pry'; binding.pry
includednext
into PryExpected behaviour:
Pry executes the next line.
Observed behaviour:
Pry crashes. Stacktrace:
Investigation:
I believe this is the case because pry-byebug needs to be required before
Pry.start
is executed so thatpry-byebug/lib/pry-byebug/pry_ext.rb
Line 17 in 34ba676
applies. This was previously achieved because prior to executing
Pry.start
and actually loading the plugins, Pry would load the cli options throughPry::CLI.add_plugin_options
. Sincelib/pry-byebug/cli.rb
loaded everything, this worked.This has now changed because you need to require pry-byebug in your .pryrc and
Pry.load_rc_files
is executed afterPry.start
.As a hacky fix,
Pry.load_rc_files
can be added topry/lib/pry.rb
. This will load .pryrc and therefore require pry-byebug before Pry is started.Questions:
The text was updated successfully, but these errors were encountered: