Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when changing value for --rules.max-concurrent-evals, –query.max-concurrency this is also need to be change. #13965

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kushalShukla-web
Copy link
Contributor

@kushalShukla-web kushalShukla-web commented Apr 21, 2024

No description provided.

…urrent-evals we should adjust query.max-concurrency
@kushalShukla-web kushalShukla-web changed the title added a new line When changing the value for rules.max-concurrent-evals please adjust the value for query.max-concurrency as the rules manager uses the same query engine than the API: when changing value for --rules.max-concurrent-evals, –query.max-concurrency this is also need to be change. Apr 21, 2024
@kushalShukla-web
Copy link
Contributor Author

fixes #13931

Copy link
Collaborator

@machine424 machine424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

cmd/prometheus/main.go Outdated Show resolved Hide resolved
kushalShukla-web and others added 2 commits April 24, 2024 16:09
Co-authored-by: Ayoub Mrini <ayoubmrini424@gmail.com>
Signed-off-by: Kushal shukla <85934954+kushalShukla-web@users.noreply.github.com>
@kushalShukla-web
Copy link
Contributor Author

Screenshot from 2024-04-28 06-02-49

@kushalShukla-web
Copy link
Contributor Author

kushalShukla-web commented Apr 28, 2024

hey @machine424 i think its failing because of some error in tsdb part . can we still merge this PR ?

@machine424
Copy link
Collaborator

Actually, the TestDocumentation test is failing.
Did you run make cli-documentation?

@ArthurSens
Copy link
Member

Could you also make sure your PR description is correctly linked with the related issue?

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@kushalShukla-web
Copy link
Contributor Author

sure i will do it .

@kushalShukla-web
Copy link
Contributor Author

Oh man I was so busy with exams , I will do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants