Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve --rules.max-concurrent-evals description #14022

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tesla59
Copy link
Contributor

@tesla59 tesla59 commented May 1, 2024

Fixes #13931

Based on #13965

builds upon suggestions in #13965 (comment) and #13965 (comment)

Signed-off-by: tesla59 <nishant@heim.id>
Co-authored-by: Kushal shukla <85934954+kushalShukla-web@users.noreply.github.com>
@tesla59
Copy link
Contributor Author

tesla59 commented May 1, 2024

create a new PR since the original PR had failing checks and it was slate for a while

@tesla59
Copy link
Contributor Author

tesla59 commented May 10, 2024

Hi @machine424
Can u review please

@machine424
Copy link
Collaborator

Thanks for the PR
But I'll ping @kushalShukla-web first to see if they're willing to continue working on #13965

@kushalShukla-web
Copy link
Contributor

kushalShukla-web commented May 13, 2024

Hey @machine424 I was busy with exams , i will complete this pr today

@machine424
Copy link
Collaborator

machine424 commented May 13, 2024

Hey @machine424 I was busy with exams , i will complete this pr today

No worries, good luck with your exams!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve --rules.max-concurrent-evals description.
3 participants