[extension/prometheusapiserverextension] feat: implement Prometheus API extension #32646
+1,776
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracewehner
requested review from
Aneurysm9,
dashpole and
a team
as code owners
|
Thanks @Aneurysm9 and @dashpole, I have made the changes we discussed. Please let me know if I should revert this back to all being inside the prometheus receiver. This PR is also dependent on prometheus/prometheus#13932 to be merged first. |
I think that is what we had decided in the last meeting, right? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Looks like the promethues PR linked above was merged. Do we need to wait for a release of prometheus/prometheus? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add Prometheus API as an extension for debugging purposes to be able to see the targets, config, and service discovery for what the prometheus receiver is scraping. This uses the Prometheus API packages in order to duplicate less code. It follows the same design to host the server as the Prometheus UI web handler.
Link to tracking Issue:
Issue: open-telemetry/wg-prometheus#63
Relevant PR discussions:
Testing:
Ran an otelcollector with prometheusreceiver and extension.
Added tests to ensure all expected paths in the API are working and all go routines are cleaned up
Documentation:
Added to READMEs for extension and prometheusreceiver