New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade codemirror and lezer to the latest version #10841
Conversation
build is failing because of the warnings :/ |
Do you think so? 243 seems to indicate a permission denied issue, which is caused by trying to crate /.npm |
ah I was looking at the tests jobs where the warning was the root cause. But yeah the |
How do you know it is trying to create a folder |
Looks good for me. Just make sure to bump |
yeah it's done automatically @MrDeerly. It's a npm workspace, so codemirror-promql is currently using the local version of lezer-promql. |
By looking at #10840, it doesn't look like the build failure is related to this PR actually. It looks like it's a general issue actually :/ |
@@ -45,7 +45,7 @@ ui-install: | |||
|
|||
.PHONY: ui-build | |||
ui-build: | |||
cd $(UI_PATH) && npm run build | |||
cd $(UI_PATH) && CI="" npm run build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason behind this unsetting of the CI
variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's because there are some warnings raised coming from some dependencies in node-modules
. I didn't find other way to ignore them than like that.
Like that warnings are not treated as errors
505839c
to
c5e148d
Compare
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
c5e148d
to
30fd158
Compare
👍 Don't super like the |
* bump codemirror to v0.20.x and lezer to v.0.16.x Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * bump codemirror to v6 and lezer to v1 Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * stop treating warning as error for UI Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@MrDeerly it should be installed in |
No description provided.