Skip to content
This repository has been archived by the owner on Jul 11, 2022. It is now read-only.

Update to Codemirror 0.20.X #190

Closed
MrDeerly opened this issue Jun 1, 2022 · 9 comments
Closed

Update to Codemirror 0.20.X #190

MrDeerly opened this issue Jun 1, 2022 · 9 comments

Comments

@MrDeerly
Copy link

MrDeerly commented Jun 1, 2022

Codemirror has been updated to v0.20 include some breaking changes which sadly breaks the backward compatibility to this package.

https://discuss.codemirror.net/t/release-0-20-0/4302

@Nexucis
Copy link
Member

Nexucis commented Jun 9, 2022

It looks like Codemirror has been released under a stable version (v6). Hopefully that will be the last time we foresee a breaking change.

@MrDeerly
Copy link
Author

MrDeerly commented Jun 9, 2022

It looks like Codemirror has been released under a stable version (v6). Hopefully that will be the last time we foresee a breaking change.

Nice!

If you need help upgrading just poke me, i already did it for private use (in a dirty way 😂). Just a headsup lezer / lezer-promql needs also to be updated.

General question: Where should PRs be created? In the individual repos or in the main prom repo?

@Nexucis
Copy link
Member

Nexucis commented Jun 9, 2022

I'm currently working on upgrading codemirror no worries :).
The PR will go to the main prometheus repo.

The main "issue" I would say is more we stopped the sync between the prom main repo and this one. It was needed in order to clean the UI folder in the prom repository.

So another work will be to re enable the publication of this package.

@Nexucis
Copy link
Member

Nexucis commented Jun 9, 2022

If you need help upgrading just poke me, i already did it for private use (in a dirty way 😂)

I guess that's where lezer-promql20 is coming from :)

@Nexucis
Copy link
Member

Nexucis commented Jun 9, 2022

here the PR that is upgrading codemirror and lezer to the latest version: prometheus/prometheus#10841

@MrDeerly
Copy link
Author

MrDeerly commented Jun 9, 2022

Awesome, I'll take a quick look and compare it with my changes later! :)

I'll also remove my npm packages (which shouldn't be public in the first place) once the updated version is online

@Nexucis
Copy link
Member

Nexucis commented Jun 16, 2022

The prometheus/prometheus#10841 has been approved and merged which fixed this issue.
Now we just have to published the new version.

@Nexucis Nexucis closed this as completed Jun 16, 2022
@MrDeerly
Copy link
Author

Awesome, thanks alot! Any idea when this will happen?

@Nexucis
Copy link
Member

Nexucis commented Jun 22, 2022

To be able to publish the new version, this PR prometheus/prometheus#10876 needs to be merged
I hope it will be merged before the next Prometheus release that should happen next week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants