Update to Codemirror 0.20.X #190
Comments
It looks like Codemirror has been released under a stable version (v6). Hopefully that will be the last time we foresee a breaking change. |
Nice! If you need help upgrading just poke me, i already did it for private use (in a dirty way 😂). Just a headsup lezer / lezer-promql needs also to be updated. General question: Where should PRs be created? In the individual repos or in the main prom repo? |
I'm currently working on upgrading codemirror no worries :). The main "issue" I would say is more we stopped the sync between the prom main repo and this one. It was needed in order to clean the UI folder in the prom repository. So another work will be to re enable the publication of this package. |
I guess that's where lezer-promql20 is coming from :) |
here the PR that is upgrading codemirror and lezer to the latest version: prometheus/prometheus#10841 |
Awesome, I'll take a quick look and compare it with my changes later! :) I'll also remove my npm packages (which shouldn't be public in the first place) once the updated version is online |
The prometheus/prometheus#10841 has been approved and merged which fixed this issue. |
Awesome, thanks alot! Any idea when this will happen? |
To be able to publish the new version, this PR prometheus/prometheus#10876 needs to be merged |
Codemirror has been updated to v0.20 include some breaking changes which sadly breaks the backward compatibility to this package.
https://discuss.codemirror.net/t/release-0-20-0/4302
The text was updated successfully, but these errors were encountered: