Use errors.Is() for invalid argument #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using Go errors.Is() to check for the "invalid argument" error. Signed-off-by: SuperQ <superq@gmail.com>
|
@SuperQ @discordianfish turns out this PR now prematurely terminates parsing on at least some systems (RHEL, Fedora) because the "invalid argument" error is actually a Should I do a patch with a function that checks errors.Is(err, syscall.Errno) and compares to EINVAL, or should we revert? |
dcbw
added a commit
to dcbw/procfs
that referenced
this pull request
May 10, 2023
prometheus#483 introduced a bug that terminates attribute reading when the returned error is syscall.Errno, which is what util.SysReadFile() will typically return. Handle that case specifically. While doing that pull the error checking into ParseNetClassAttribute() for clarity and to allow external callers to handle errors correctly. Signed-off-by: Dan Williams <dcbw@redhat.com>
dcbw
added a commit
to dcbw/procfs
that referenced
this pull request
May 10, 2023
prometheus#483 introduced a bug that terminates attribute reading when the returned error is syscall.Errno, which is what util.SysReadFile() will typically return. Handle that case specifically. While doing that pull the error checking into ParseNetClassAttribute() for clarity and to allow external callers to handle errors correctly. Signed-off-by: Dan Williams <dcbw@redhat.com>
dcbw
added a commit
to dcbw/procfs
that referenced
this pull request
May 10, 2023
prometheus#483 introduced a bug that terminates attribute reading when the returned error is syscall.Errno, which is what util.SysReadFile() will typically return. Handle that case specifically. While doing that pull the error checking into ParseNetClassAttribute() for clarity and to allow external callers to handle errors correctly. Signed-off-by: Dan Williams <dcbw@redhat.com>
dcbw
added a commit
to dcbw/procfs
that referenced
this pull request
May 15, 2023
prometheus#483 introduced a bug that terminates attribute reading when the returned error is syscall.Errno, which is what util.SysReadFile() will typically return. Handle that case specifically. While doing that pull the error checking into ParseNetClassAttribute() for clarity and to allow external callers to handle errors correctly. Signed-off-by: Dan Williams <dcbw@redhat.com>
discordianfish
pushed a commit
that referenced
this pull request
May 17, 2023
#483 introduced a bug that terminates attribute reading when the returned error is syscall.Errno, which is what util.SysReadFile() will typically return. Handle that case specifically. While doing that pull the error checking into ParseNetClassAttribute() for clarity and to allow external callers to handle errors correctly. Signed-off-by: Dan Williams <dcbw@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using Go errors.Is() to check for the "invalid argument" error.
Signed-off-by: SuperQ superq@gmail.com