net_class: catch syscall.EINVAL and better handle read errors #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbw
force-pushed
the
net-class-better-errors
branch
2 times, most recently
from
c2cef03
to
8c34065
Compare
SuperQ
reviewed
May 11, 2023
sysfs/net_class.go
Outdated
| if isFatalError(err) { | ||
| return fmt.Errorf("failed to read file %q: %w", attrPath, err) | ||
| } | ||
| return nil |
There was a problem hiding this comment.
Hmm, what errors are we going to ignore by doing this?
There was a problem hiding this comment.
@SuperQ No more errors than we ignored before... It uses the same logic, but now additionally ignores the syscall.Errno(EINVAL)
|
Maybe we should inverse this, all errors are fatal unless they're in a list of allowed non-fatal errors. |
@SuperQ that's effectively what the code is already doing (and was doing before); but perhaps my function name is not as clear. I can reverse the meaning if you'd like. |
prometheus#483 introduced a bug that terminates attribute reading when the returned error is syscall.Errno, which is what util.SysReadFile() will typically return. Handle that case specifically. While doing that pull the error checking into ParseNetClassAttribute() for clarity and to allow external callers to handle errors correctly. Signed-off-by: Dan Williams <dcbw@redhat.com>
dcbw
force-pushed
the
net-class-better-errors
branch
from
8c34065
to
a12f2c5
Compare
|
@SuperQ flipped meaning to |
discordianfish
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#483 introduced a bug that terminates attribute reading when the returned error is
syscall.Errno, which is whatutil.SysReadFile()will typically return. Handle that case specifically.While doing that pull the error checking into
ParseNetClassAttribute()for clarity and to allow external callers to handle errors correctly.@SuperQ @discordianfish