-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cpuinfo for loongarch64 #384
Conversation
e20eb30
to
8a07a2a
Compare
@SuperQ Hello, I added cpuinfo for loongarch64, at the same time I have compiled and tested locally, and have used the codes in other projects without any problems. can you help me to review the code? Thank you |
Thanks, I'll take a look at this soon. |
Oh exciting! I don't think it's possible to get loongarch64 systems anywhere yet, right? Or do you know a way? So I can't really verify this.. |
The LoongArch kernel support hasn't been upstream yet; even the first submission is yet to appear. So in theory the |
I'm fine either way, merging this also wouldn't break anything so.. @zhangwenlong8911 Do you know if I can buy a loongarch64 system somewhere online? Or how did you get your hands on one? |
FYI, the initial LoongArch kernel bits appeared; but it's still long before being mainlined, so technically things could still change. For now the |
@discordianfish I am a member of the loongarch64 team, so I can get first-hand information, LoongArch kernel support has been submitted to the kernel community |
8a07a2a
to
aab631e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't we using "loong/loong64" everywhere in the Go land instead of "loongarch/loongarch64"? Plus the /proc/cpuinfo
format issue hasn't settled yet. We really should wait a bit longer.
+1 for consistency, if it's called 'loong(64)' in golang, let's do it here as well. |
I think you are right@xen0n @discordianfish, I modify the architecture information now, about / proc / cpuinfo, let's wait |
aab631e
to
2b365b0
Compare
2b365b0
to
344b47c
Compare
378e2bc
to
803fb4e
Compare
803fb4e
to
854ecef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to test your code on multiple arches (at least test amd64 too, in your case).
Finally, please add While at it, modify your PR title and commit message so LoongArch64 is uniformly referred to as |
178641c
to
7e5271b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Wenlong Zhang <zhangwenlong@loongson.cn>
7e5271b
to
3607457
Compare
Go 1.19 finally supports this platform. |
Signed-off-by: Wenlong Zhang <zhangwenlong@loongson.cn>
No description provided.