Update build/test #353
Merged
Update build/test #353
+54
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @mrueg |
mrueg
reviewed
Jan 7, 2022
|
the build tags in: |
mrueg
added a commit
to mrueg/prometheus-client_golang
that referenced
this pull request
Jan 31, 2022
As requested in prometheus/common#353 (comment) Signed-off-by: Manuel Rüger <manuel@rueg.eu>
mrueg
reviewed
Jan 31, 2022
mrueg
added a commit
to mrueg/prometheus-client_golang
that referenced
this pull request
Jan 31, 2022
As requested in prometheus/common#353 (comment) Signed-off-by: Manuel Rüger <manuel@rueg.eu>
SuperQ
force-pushed
the
superq/bump_go
branch
from
abf03eb
to
b4f3fd6
Compare
|
Bleh, deprecated use linter errors. |
|
@SuperQ I assume those could be treated similar to Let me know if there's anything I can do to get this into a state in which it can be merged. |
SuperQ
force-pushed
the
superq/bump_go
branch
from
b4f3fd6
to
19f4cca
Compare
* Use `make -C dir` instead of `cd dir && make` * Cleanup uncessary working_directory in config. * Update Go modules to latest. * Drop support for old Go versions. * Cleanup old Go version build tweaks. * Fixup some deprecated method use. Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/bump_go
branch
from
19f4cca
to
3c43b4d
Compare
|
Ok, let me know if the changes to |
roidelapluie
approved these changes
Mar 15, 2022
|
I think they are fine. |
beorn7
approved these changes
Mar 17, 2022
Cori1109
added a commit
to Cori1109/client_golang
that referenced
this pull request
Jan 9, 2023
As requested in prometheus/common#353 (comment) Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make -C dirinstead ofcd dir && makeSigned-off-by: SuperQ superq@gmail.com