Merge pull request #784 from hummerd/master

Remove reference to Metric after reslicing
prometheus · Jul 24, 2020 · c650ae9 · c650ae9
2 parents 77b35d0 + 0c48254
commit c650ae9
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/prometheus/vec.go b/prometheus/vec.go
@@ -276,7 +276,9 @@ func (m *metricMap) deleteByHashWithLabelValues(
 	}
 
 	if len(metrics) > 1 {
+		old := metrics
 		m.metrics[h] = append(metrics[:i], metrics[i+1:]...)
+		old[len(old)-1] = metricWithLabelValues{}
 	} else {
 		delete(m.metrics, h)
 	}
@@ -302,7 +304,9 @@ func (m *metricMap) deleteByHashWithLabels(
 	}
 
 	if len(metrics) > 1 {
+		old := metrics
 		m.metrics[h] = append(metrics[:i], metrics[i+1:]...)
+		old[len(old)-1] = metricWithLabelValues{}
 	} else {
 		delete(m.metrics, h)
 	}