Skip to content

Commit

Permalink
Merge pull request #783 from roidelapluie/gc15
Browse files Browse the repository at this point in the history
Update collector comment about GC stop-the-world
  • Loading branch information
beorn7 committed Jul 24, 2020
2 parents d3accfd + 4759649 commit 77b35d0
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions prometheus/go_collector.go
Expand Up @@ -58,9 +58,10 @@ type goCollector struct {
// collector will use the memstats from a previous collection if
// runtime.ReadMemStats takes more than 1s. However, if there are no previously
// collected memstats, or their collection is more than 5m ago, the collection
// will block until runtime.ReadMemStats succeeds. (The problem might be solved
// in Go1.13, see https://github.com/golang/go/issues/19812 for the related Go
// issue.)
// will block until runtime.ReadMemStats succeeds.
//
// NOTE: The problem is solved in Go 1.15, see
// https://github.com/golang/go/issues/19812 for the related Go issue.
func NewGoCollector() Collector {
return &goCollector{
goroutinesDesc: NewDesc(
Expand Down

0 comments on commit 77b35d0

Please sign in to comment.