Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker-compose): Expose YAML file as property #2866

Merged
merged 5 commits into from Aug 29, 2023

Conversation

icj217
Copy link
Contributor

@icj217 icj217 commented Aug 18, 2023

The docker compose components don't fully implement the compose spec, so there's often a need to directly extend/mutate the YAML file. Making the file accessible in the same way that it's done in a lot of other components.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@icj217 icj217 marked this pull request as ready for review August 18, 2023 19:26
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Merging #2866 (1a79281) into main (e93fadd) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 95.73%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##             main    #2866    +/-   ##
========================================
  Coverage   96.41%   96.41%            
========================================
  Files         181      181            
  Lines       33697    33842   +145     
  Branches     3103     3127    +24     
========================================
+ Hits        32488    32628   +140     
- Misses       1209     1214     +5     
Files Changed Coverage Δ
src/github/pull-request-lint.ts 96.88% <95.07%> (-3.12%) ⬇️
src/docker-compose/docker-compose.ts 100.00% <100.00%> (ø)
src/github/pr-template.ts 100.00% <100.00%> (ø)
src/javascript/eslint.ts 98.01% <100.00%> (ø)

... and 1 file with indirect coverage changes

@mrgrain
Copy link
Contributor

mrgrain commented Aug 28, 2023

@icj217 Can't merge this until the PR description includes the following license footer.

---
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mrgrain mrgrain added the pr/do-not-merge ⚙️ used by automation label Aug 28, 2023
@mrgrain mrgrain removed the pr/do-not-merge ⚙️ used by automation label Aug 29, 2023
@icj217
Copy link
Contributor Author

icj217 commented Aug 29, 2023

@icj217 Can't merge this until the PR description includes the following license footer.

@mrgrain Fixed! Sorry about that. Also added a test to inspect the new property.

@mrgrain
Copy link
Contributor

mrgrain commented Aug 29, 2023

@mrgrain Fixed! Sorry about that. Also added a test to inspect the new property.

No worries! This prompted me to finally add an automated check for it 😂
Thanks for the test as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants