fix(github): bump upload/download artifact actions to v4; resolves runtime deprecation warnings #3335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icj217
force-pushed
the
bump_app_token_action
branch
from
7e46da8
to
f11e1a0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3335 +/- ##
=======================================
Coverage 96.28% 96.29%
=======================================
Files 191 191
Lines 36709 36720 +11
Branches 3435 3436 +1
=======================================
+ Hits 35347 35360 +13
+ Misses 1362 1360 -2 ☔ View full report in Codecov by Sentry. |
icj217
changed the title
mrgrain
requested changes
Feb 7, 2024
11 tasks
…eprecation warnings
icj217
force-pushed
the
bump_app_token_action
branch
from
d686824
to
8d2b97b
Compare
icj217
changed the title
Sure thing. Here's the separate PR |
mrgrain
changed the title
mrgrain
reviewed
Feb 9, 2024
Co-authored-by: Momo Kornher <mail@moritzkornher.de>
mrgrain
changed the title
mrgrain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update artifact-related github actions that are generating warnings in projects due to nodejs 16 being deprecated in github actions runners.
v4 of actions/upload-artifact introduced some breaking changes, so we've set
overwriteto be true by default to mirror the previous behavior as closely as possible.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.